From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60064)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Yo0Fi-0004s2-7T
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 22:00:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Yo0Fe-0000UL-GL
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 22:00:30 -0400
Received: from ozlabs.org ([2401:3900:2:1::2]:47991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Yo0Fe-0000U1-4u
	for qemu-devel@nongnu.org; Thu, 30 Apr 2015 22:00:26 -0400
Date: Fri, 1 May 2015 11:29:23 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20150501012923.GH24886@voom.redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="/Gk0KcsbyUMelFU1"
Content-Disposition: inline
Subject: [Qemu-devel] qemu-ga and logging domain
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org


--/Gk0KcsbyUMelFU1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Michael,

I was just looking at some of the logging stuff in qemu-ga, and it
seems to be doing something very odd with the "domain".

static void ga_log(const gchar *domain, GLogLevelFlags level,
                   const gchar *msg, gpointer opaque)
{
    GAState *s =3D opaque;
    GTimeVal time;
    const char *level_str =3D ga_log_level_str(level);

    if (!ga_logging_enabled(s)) {
        return;
    }

    level &=3D G_LOG_LEVEL_MASK;
#ifndef _WIN32
    if (domain && strcmp(domain, "syslog") =3D=3D 0) {
        syslog(LOG_INFO, "%s: %s", level_str, msg);
    } else if (level & s->log_level) {
#else
    if (level & s->log_level) {
#endif
        g_get_current_time(&time);
        fprintf(s->log_file,
                "%lu.%lu: %s: %s\n", time.tv_sec, time.tv_usec, level_str, =
msg);
        fflush(s->log_file);
    }
}

This is sending messages to syslog instead of a logfile if domain is
set to "syslog".  But the log domain is usually about where the
messages came from, not where they're going.

What's up with this?

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--/Gk0KcsbyUMelFU1
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVQtbzAAoJEGw4ysog2bOSukQP/3EAMuqUSMOGYwPBVsWYHUlK
ZxkflpSwTMILeS3YYfSZ8iYaSuxR5pm8ZoIwjEAagj2ZJYvNJx1tRIhR502UfNCV
1IEolBZIMP637tu/7vrx1fq7queRO6+GB+nio2YL3kXYlbVoF2GS5ay5VLBKov1P
60S3yrbNB1QLiCmWirVHffVU346869lMqqRPe/IldAABv2iGJp71PkGXQZS5KZqf
UB4eNhI21okIW0xPq+6BAOStsNf4UQztzswPYNj9XfUrPAHPEVGLM52aIU+wSV7A
wBdkklQhQSYEUMoI2Ijr6nKS8BIx5UMFVvHCSsRhAXM7WMO3uco33q93UByQVIK5
e84ZmzYpRGzvZqqCgjpfS3jhe/FL1md0omz+LoVh0WSFrTUpWdNEIvz5AB957kka
XL8LTd7zGSXeoRwBYT8eR3h1RomJ4htz8Oq4GqtSR0ng0oHJbZFV4FYVKEAVzoGq
DwbZqbecbNITaRZesKd52PRMbFXA4YlMUDAhsNnv4WuNJaYoVDUkxzhSh1e6GbQV
meh+X0/wtdayCdCG7QP3pcRWV0fUsGbNOxCgbydqSfiXCfeVFIib7RsCNhSAfdlA
bFO8u2Q2/wMxs8C0bH7E2X8MXJGIeWudbf7T1CppPhqVw9RBoLIE/r1whI+gMcIy
x6dFnESr3sLvIO95xqUO
=3cWz
-----END PGP SIGNATURE-----

--/Gk0KcsbyUMelFU1--