From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39427)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YpCjX-00006j-06
	for qemu-devel@nongnu.org; Mon, 04 May 2015 05:32:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YpCjU-0000Xw-BR
	for qemu-devel@nongnu.org; Mon, 04 May 2015 05:32:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YpCjU-0000Xi-54
	for qemu-devel@nongnu.org; Mon, 04 May 2015 05:32:12 -0400
Date: Mon, 4 May 2015 15:01:56 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150504093156.GF6965@grmbl.mre>
References: <1414141254-31960-1-git-send-email-marcandre.lureau@gmail.com>
	<1414141254-31960-2-git-send-email-marcandre.lureau@gmail.com>
	<1414397322.9909.4.camel@nilsson.home.kraxel.org>
	<CAJ+F1CK7mnW3v5+5Cg29STeBtP7gamVtCi47R06LiXDF5cB9uA@mail.gmail.com>
	<1414411077.9909.12.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1414411077.9909.12.camel@nilsson.home.kraxel.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when
 chardev is writable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org

Hi Gerd,

On (Mon) 27 Oct 2014 [12:57:57], Gerd Hoffmann wrote:
> On Mo, 2014-10-27 at 12:45 +0100, Marc-Andr=E9 Lureau wrote:
> > Hi
> >=20
> >=20
> > On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann <kraxel@redhat.com>
> > wrote:
> >         > +static void spice_chr_accept_input(struct CharDriverState
> >         *chr)
> >         > +{
> >         > +    SpiceCharDriver *s =3D chr->opaque;
> >         > +
> >         > +    spice_server_char_device_wakeup(&s->sin);
> >        =20
> >        =20
> >         Does this build on older spice versions?  I'd suspect this
> >         needs #if
> >         SPICE_SERVER_VERSION too ...
> >=20
> >=20
> > There is already a spice_server_char_device_wakeup() call there. On
> > older servers, this additional call will trigger just a read try. Wit=
h
> > the proposed patch in Spice server, it will do read & write try (I
> > didn't see the need to create a new function to do only read or write=
,
> > both should be fine)
>=20
> Ok then.  Added to spice queue.  Fails to build, but that looks like
> just being the dependency on amits patch and should go away once that
> one is upstream.

The dependency patch is now in tree, please pick this series up.

Thanks,


		Amit