From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu block <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Don Slutz <dslutz@verizon.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw
Date: Mon, 4 May 2015 16:17:35 +0200 [thread overview]
Message-ID: <20150504141735.GH3676@noname.str.redhat.com> (raw)
In-Reply-To: <87383ca2ci.fsf@blackfin.pond.sub.org>
Am 04.05.2015 um 15:39 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > Am 01.05.2015 um 01:28 hat Don Slutz geschrieben:
> [...]
> >> So do you want a more complex patch that allows the format to be
> >> specified?
> >>
> >> Only for 'disk_image'?
> >>
> >> Include -hd* ?
> >
> > I'm afraid that there is no nice way to improve the plain 'disk_image'
> > case. You would have to add another option, and then it's not any better
> > than -hda and friends any more.
> >
> > -hda in turn could be extended to take additional options (i.e. it
> > becomes something like -drive with implied index=0), but then there's
> > little reason not to use -drive.
>
> Would likely break images with ',' in their name.
A possible justification would be that -hda is a convenience option
that, similar to HMP, is meant only for human users and if you use it in
scripts and it changes, you get to keep both pieces. In addition, while
some use cases would be affected, most of them wouldn't, even in
scripts.
Whether or not this justification is valid might be controversial.
Kevin
prev parent reply other threads:[~2015-05-04 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 18:23 [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw Don Slutz
2015-04-30 19:15 ` Eric Blake
2015-04-30 19:17 ` Eric Blake
2015-04-30 20:15 ` Kevin Wolf
2015-04-30 23:28 ` Don Slutz
2015-05-04 11:08 ` Kevin Wolf
2015-05-04 13:39 ` Markus Armbruster
2015-05-04 14:17 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504141735.GH3676@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=dslutz@verizon.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).