From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YpHBm-0008ML-RZ
	for qemu-devel@nongnu.org; Mon, 04 May 2015 10:17:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YpHBi-0000Xn-S6
	for qemu-devel@nongnu.org; Mon, 04 May 2015 10:17:42 -0400
Date: Mon, 4 May 2015 16:17:35 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150504141735.GH3676@noname.str.redhat.com>
References: <1430418196-8691-1-git-send-email-dslutz@verizon.com>
	<55427F5A.5090608@redhat.com>
	<20150430201534.GB3545@noname.redhat.com>
	<5542BAA2.3060802@Verizon.com>
	<20150504110841.GE3676@noname.str.redhat.com>
	<87383ca2ci.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87383ca2ci.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that
 'disk_image' is a raw hard disk image, pass format=raw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu block <qemu-block@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Don Slutz <dslutz@verizon.com>

Am 04.05.2015 um 15:39 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > Am 01.05.2015 um 01:28 hat Don Slutz geschrieben:
> [...]
> >> So do you want a more complex patch that allows the format to be
> >> specified?
> >> 
> >> Only for 'disk_image'?
> >> 
> >> Include -hd* ?
> >
> > I'm afraid that there is no nice way to improve the plain 'disk_image'
> > case. You would have to add another option, and then it's not any better
> > than -hda and friends any more.
> >
> > -hda in turn could be extended to take additional options (i.e. it
> > becomes something like -drive with implied index=0), but then there's
> > little reason not to use -drive.
> 
> Would likely break images with ',' in their name.

A possible justification would be that -hda is a convenience option
that, similar to HMP, is meant only for human users and if you use it in
scripts and it changes, you get to keep both pieces. In addition, while
some use cases would be affected, most of them wouldn't, even in
scripts.

Whether or not this justification is valid might be controversial.

Kevin