From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpXXP-0001aL-AI for qemu-devel@nongnu.org; Tue, 05 May 2015 03:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpXXO-0002y4-Ax for qemu-devel@nongnu.org; Tue, 05 May 2015 03:45:07 -0400 Date: Tue, 5 May 2015 17:01:19 +1000 From: David Gibson Message-ID: <20150505070119.GK14090@voom.redhat.com> References: <1429858066-12088-1-git-send-email-bharata@linux.vnet.ibm.com> <1429858066-12088-14-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MHXEHrrXKLGx71o" Content-Disposition: inline In-Reply-To: <1429858066-12088-14-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v3 13/24] cpus: Add Error argument to cpu_exec_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de --3MHXEHrrXKLGx71o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 24, 2015 at 12:17:35PM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. Change all callers to currently pass NULL error argument. This cha= nge > is needed for the following reasons: >=20 > - A subsequent commit changes the CPU enumeration logic in cpu_exec_init() > resulting in cpu_exec_init() to fail if cpu_index values corresponding > to max_cpus have already been handed out. > - There is a thinking that cpu_exec_init() should be called from realize > rather than instance_init. With this change, those architectures > that can move this call into realize function can do so in a phased > manner. >=20 > Signed-off-by: Bharata B Rao > Reviewed-by: David Gibson Again, looks good to me, but I'm not sure whose tree it needs to go through. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3MHXEHrrXKLGx71o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSGq/AAoJEGw4ysog2bOSddsP/iYbgMt6UtWmuqnEybgzL3Ec OKZ5qvLdvjPOZPObKmrvStjXs1x/VCPDUMsector5UsKRuczOQvvXnG9ED+2GqIh jmme9MYQQh/RAUNSOumjeLcJjfCPdnd+Q4nPsPVIyHeTEpzRPuEMQD8Rm6Ebsh+Y gVW8e1OS6bse+1rPCY2BTCJZzM4mHZL1wyg3IS8DyRTfskBHevVAdLlQvGHv7GVc WaXQd1zk7IwcFKY23Uf0KZq8q7OQU2xC6/IBNOJ8zxP0UlwO2CqRetOoD6aRf43c 9rxCRSJAdv1K4RsB5cE+T8bu3WUfG+cGEIMKohuWqWVOes6s3xO+j7PNFxvkB2cz 6nKbmftab+nLRV3dPvZrmhpEENmkaEAoTnKKjyHRsoDB2nxkde23vLS5HIILKiRb dC3jb78p0jL5UDSsSdj2RFq085bFpDYoYYw1W098qNW9ITDYudD3HSTJKXiMzd0q HB0TLy7fQRkJXm5y9d3fKoJl5bAdk8SkieXDl2L2mdOKjEkIT37sicc3GxU4mxfs HAcOXEslS327SkJRv7pitQ6aNgZ2suCbMDrDmM3eupf6nxPsGe4yf5M6ua7S7tGr lvZuYMr5yRkp5U4v6t02gsOyBVOs+zuOd5u1y9hrKbDrSgNZH0rRzTyZsTAcSQl8 M95uqtCkoMhbkypXtQhb =FSsb -----END PGP SIGNATURE----- --3MHXEHrrXKLGx71o--