From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpXeA-0005YK-LN for qemu-devel@nongnu.org; Tue, 05 May 2015 03:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpXe7-0005CQ-Bh for qemu-devel@nongnu.org; Tue, 05 May 2015 03:52:06 -0400 Received: from ozlabs.org ([103.22.144.67]:58396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpXe7-0005C7-1z for qemu-devel@nongnu.org; Tue, 05 May 2015 03:52:03 -0400 Date: Tue, 5 May 2015 17:51:27 +1000 From: David Gibson Message-ID: <20150505075127.GW14090@voom.redhat.com> References: <1430766598-8512-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3wyj3Xt2kUWLNC5K" Content-Disposition: inline In-Reply-To: <1430766598-8512-1-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qmp: Add qom-path field to query-cpus command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mimu@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, Paolo Bonzini , cornelia.huck@de.ibm.com, Igor Mammedov , Jiri Denemark , lcapitulino@redhat.com, Andreas =?iso-8859-1?Q?F=E4rber?= --3wyj3Xt2kUWLNC5K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 04, 2015 at 04:09:58PM -0300, Eduardo Habkost wrote: > This will allow clients to query additional information directly using > qom-get on the CPU objects. >=20 > Signed-off-by: Eduardo Habkost I'm not sure if it's the only way to accomplish what we need in these new schemes, but it seems like a reasonable thing to have regardless. Reviewed-by: David Gibson > --- > Reference to previous discussion: >=20 > Date: Mon, 4 May 2015 15:37:40 -0300 > From: Eduardo Habkost > Message-ID: <20150504183740.GM17796@thinpad.lan.raisama.net> > Subject: Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/c= pus/ >=20 > The summary is: even if we provide predictable QOM paths for the CPU > objects, the qom-path field will be useful to allow the QOM objects and > query-cpu data to be matched correctly. > --- > cpus.c | 1 + > qapi-schema.json | 7 +++++-- > qmp-commands.hx | 1 + > 3 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/cpus.c b/cpus.c > index 62d157a..de6469f 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1435,6 +1435,7 @@ CpuInfoList *qmp_query_cpus(Error **errp) > info->value->CPU =3D cpu->cpu_index; > info->value->current =3D (cpu =3D=3D first_cpu); > info->value->halted =3D cpu->halted; > + info->value->qom_path =3D object_get_canonical_path(OBJECT(cpu)); > info->value->thread_id =3D cpu->thread_id; > #if defined(TARGET_I386) > info->value->has_pc =3D true; > diff --git a/qapi-schema.json b/qapi-schema.json > index ac9594d..7a52a78 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -602,6 +602,8 @@ > # @halted: true if the virtual CPU is in the halt state. Halt usually r= efers > # to a processor specific low power mode. > # > +# @qom-path: path to the CPU object in the QOM tree. > +# > # @pc: #optional If the target is i386 or x86_64, this is the 64-bit ins= truction > # pointer. > # If the target is Sparc, this is the PC component of the > @@ -622,8 +624,9 @@ > # data is sent to the client, the guest may no longer be halted. > ## > { 'type': 'CpuInfo', > - 'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool', '*pc': 'in= t', > - '*nip': 'int', '*npc': 'int', '*PC': 'int', 'thread_id': 'int= '} } > + 'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool', 'qom-path'= : 'str', > + '*pc': 'int', '*nip': 'int', '*npc': 'int', '*PC': 'int', > + 'thread_id': 'int'} } > =20 > ## > # @query-cpus: > diff --git a/qmp-commands.hx b/qmp-commands.hx > index d4a837c..5c92162 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -2569,6 +2569,7 @@ Return a json-array. Each CPU is represented by a j= son-object, which contains: > - "CPU": CPU index (json-int) > - "current": true if this is the current CPU, false otherwise (json-bool) > - "halted": true if the cpu is halted, false otherwise (json-bool) > +- "qom-path": path to the CPU object in the QOM tree (json-str) > - Current program counter. The key's name depends on the architecture: > "pc": i386/x86_64 (json-int) > "nip": PPC (json-int) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3wyj3Xt2kUWLNC5K Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSHZ/AAoJEGw4ysog2bOS2QAP/2A8qFsKKoM/UOky6qvhbe58 2bd0ZSalek2NM4OJ+MDaANOFeVgqaD9SN40nwuLbaD9SWpWqrDa5wXu60hQ9AB1N 7MYWIy4d291KhqXeHVDV4O1S3tnDejPIbyfpizt1pd4q6aJvdL89AcW4JiuhCXZr PlGsPp46xCHU+xK5m/mCvS181/IdTlMUMFSG5FE/Gw9cRZ23r6BXwBRI5VSC9vut j4Itbuk3FxyhvsglWO56o5clXu2b5XDRIJ5SK6UBCCG34RNZkjljGaVG2tVUrtN9 rqTI1KleHnWKsiTwCZjcYdynsRO6FB3+z+zwf89NIpGfkLNLFb1hTvF3mFmdnggn mPETzYgbjuuLGUDS4CPrZI+YqUsdmc5hctyCay8VHsTvYMRvO9TDbw3AmVg77MVu 0Wut9EgnZ15kgsF6oylsVIwgtJnI1/5vBYPOoVmMTdwOvgpYyN9fltDs1MVFrIqD cm6HWaxvaf5773YFWWn4MMh3RdP7A6JrOO3Ze3l0rarSEJCe/+eKnEp7QV2hVEUG wHTDhVQi3+wb8i7CNa8T5aXNQiOX0qUJtZZYJmrlRhKPmCKuWbLJmEg4k2xPN0xU dsKDvvaGYWzAouwSsXMuLxMjcLQhChyFkyBXvolgzTd5loyTsOH0wnaSAjuvSy76 1FgCg6tyKk/xculZXCZv =ljdI -----END PGP SIGNATURE----- --3wyj3Xt2kUWLNC5K--