From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpZiN-0006P6-AJ for qemu-devel@nongnu.org; Tue, 05 May 2015 06:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpZiL-0002L6-Aj for qemu-devel@nongnu.org; Tue, 05 May 2015 06:04:35 -0400 Date: Tue, 5 May 2015 19:58:21 +1000 From: David Gibson Message-ID: <20150505095821.GZ14090@voom.redhat.com> References: <1430335224-6716-1-git-send-email-mdroth@linux.vnet.ibm.com> <1430335224-6716-5-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AJu7IxIPovG6hMTN" Content-Disposition: inline In-Reply-To: <1430335224-6716-5-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH 04/15] spapr_iommu: pass object ownership to parent/owner List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com --AJu7IxIPovG6hMTN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2015 at 02:20:13PM -0500, Michael Roth wrote: > DRC objects attach themselves to an owner as a child ^^^ Copy and paste error in the commit message. > property. unref afterward to allow them to be finalized > when their owner is finalized. >=20 > Signed-off-by: Michael Roth But otherwise, Reviewed-by: David Gibson > --- > hw/ppc/spapr_iommu.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index a14cdc4..79e998b 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -182,6 +182,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner= , uint32_t liobn, > =20 > snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > + object_unref(OBJECT(tcet)); > =20 > object_property_set_bool(OBJECT(tcet), true, "realized", NULL); > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --AJu7IxIPovG6hMTN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSJQ9AAoJEGw4ysog2bOSRAUP/jLc50qog6QFByGWGIMIElXH 1h6rs9KyoQGTB0q308CvacWsTWMkDkTupfk9IhUmXLLsAvdE7YFq6PuNCych4vPA BjHVMFbhMZXXIwc7GkqgZNoGTlwCy1GxbfL6Yd053Sw3TZEwgfrODPBXpXuVt64B 8ZXHOFYz4LHsD6mSgKBqdZnuUnquJnVI6DD1W566Hi1nWQduyHQQufmyburtmhi0 Kyuig9FVR+HjI8MNqSrR7ELIHCWGBwhSofTiQV3EaUr4TuKklQe1oOZ18d1cZLDz E6zJiqsatnUB78jOVp/01/8sP/5oLaseM0timB2zxpMpPdBk3D0t2Ffa/eINEiiG NxNiASODFt4KmHaT+7o1bMvhrtudc5ZJ98lnEteDZz28ebTrXZYxbV2MdX4VaSmO kjIFKF6PkE49SqiiT6qNw7suJstVKBF9XUwaR+kfJr5dXsBrbvzZ4mzTjxJOG/5T gBKHYK/VWI9bjPTT2Ifb+n7dGk7rGQPDeIMhmSX+NLC7nKn6d6rLSB+FdKJPCoup cJkhMw4JQ4QU9I9ZKVBEEzz2Vsbs6sg6d0t53d+oI2a+fOHIMLm//+vsS5WyrMtl ok1dIv9CWuPeTxoOozjjfOIQvQesNBX9IUmpHWkAdX8f1N3PJaLkCOVtHAEFZF/P T420qiEQ5Pq6aCngOIG2 =MlsJ -----END PGP SIGNATURE----- --AJu7IxIPovG6hMTN--