From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, John Snow <jsnow@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
stefanha@redhat.com, wangxiaolong@ucloud.cn
Subject: Re: [Qemu-devel] Fwd: qemu drive mirror assert fault
Date: Tue, 5 May 2015 18:27:43 +0800 [thread overview]
Message-ID: <20150505102743.GA20503@ad.nay.redhat.com> (raw)
In-Reply-To: <554897C4.20804@redhat.com>
On Tue, 05/05 12:13, Paolo Bonzini wrote:
>
>
> On 05/05/2015 09:36, Fam Zheng wrote:
> I don't think this commit is relevant. The bug is caused by
> bdrv_co_discard clearing the bitmap (which is not supported during
> iteration, and is caught by the assertion). That bdrv_reset_dirty is
> not removed by the commit you pointed out.
You are right, I think the bug is the bdrv_reset_dirty in bdrv_co_discard. The
discard may zero out the src area (depending on the backend), we should
probably replicate this to dest (actual data or the discard operation), rather
than forgetting the change.
Fam
next prev parent reply other threads:[~2015-05-05 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_D4C0F8C0FE9E16802F5FF410@qq.com>
2015-04-30 15:50 ` [Qemu-devel] Fwd: qemu drive mirror assert fault Paolo Bonzini
2015-04-30 15:54 ` Paolo Bonzini
2015-05-05 7:36 ` Fam Zheng
2015-05-05 10:13 ` Paolo Bonzini
2015-05-05 10:27 ` Fam Zheng [this message]
2015-05-05 11:48 ` Kevin Wolf
2015-05-05 11:49 ` Paolo Bonzini
2015-05-05 11:54 ` Paolo Bonzini
2015-05-05 13:03 ` Kevin Wolf
2015-05-05 13:07 ` Paolo Bonzini
2015-05-05 13:31 ` Kevin Wolf
2015-05-05 12:09 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505102743.GA20503@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).