From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypa4w-0007P3-Rz for qemu-devel@nongnu.org; Tue, 05 May 2015 06:27:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ypa4r-0003xx-P9 for qemu-devel@nongnu.org; Tue, 05 May 2015 06:27:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypa4r-0003uN-BR for qemu-devel@nongnu.org; Tue, 05 May 2015 06:27:49 -0400 Date: Tue, 5 May 2015 18:27:43 +0800 From: Fam Zheng Message-ID: <20150505102743.GA20503@ad.nay.redhat.com> References: <55424F3C.1050209@redhat.com> <20150505073609.GA9322@ad.nay.redhat.com> <554897C4.20804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554897C4.20804@redhat.com> Subject: Re: [Qemu-devel] Fwd: qemu drive mirror assert fault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, John Snow , qemu-devel , stefanha@redhat.com, wangxiaolong@ucloud.cn On Tue, 05/05 12:13, Paolo Bonzini wrote: > > > On 05/05/2015 09:36, Fam Zheng wrote: > I don't think this commit is relevant. The bug is caused by > bdrv_co_discard clearing the bitmap (which is not supported during > iteration, and is caught by the assertion). That bdrv_reset_dirty is > not removed by the commit you pointed out. You are right, I think the bug is the bdrv_reset_dirty in bdrv_co_discard. The discard may zero out the src area (depending on the backend), we should probably replicate this to dest (actual data or the discard operation), rather than forgetting the change. Fam