From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpbJX-0002KH-1t for qemu-devel@nongnu.org; Tue, 05 May 2015 07:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpbJS-0003d1-Sy for qemu-devel@nongnu.org; Tue, 05 May 2015 07:47:03 -0400 Date: Tue, 5 May 2015 21:39:11 +1000 From: David Gibson Message-ID: <20150505113911.GD14090@voom.redhat.com> References: <1430335224-6716-1-git-send-email-mdroth@linux.vnet.ibm.com> <1430335224-6716-10-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WP/lS5xSWAOC+/uo" Content-Disposition: inline In-Reply-To: <1430335224-6716-10-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH 09/15] spapr: populate PHB DRC entries for root DT node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com --WP/lS5xSWAOC+/uo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 29, 2015 at 02:20:18PM -0500, Michael Roth wrote: > From: Nathan Fontenot >=20 > This add entries to the root OF node to advertise our PHBs as being > DR-capable in accordance with PAPR specification. >=20 > Signed-off-by: Nathan Fontenot > Signed-off-by: Michael Roth > --- > hw/ppc/spapr.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index c539932..a7af332 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -57,6 +57,7 @@ > #include "qemu/error-report.h" > #include "trace.h" > #include "hw/nmi.h" > +#include "hw/ppc/spapr_drc.h" > =20 > #include "hw/compat.h" > =20 > @@ -745,6 +746,7 @@ static void spapr_finalize_fdt(sPAPREnvironment *spap= r, > size_t cb =3D 0; > char *bootlist; > void *fdt; > + int fdt_offset; > sPAPRPHBState *phb; > =20 > fdt =3D g_malloc(FDT_MAX_SIZE); > @@ -804,6 +806,13 @@ static void spapr_finalize_fdt(sPAPREnvironment *spa= pr, > spapr_populate_chosen_stdout(fdt, spapr->vio_bus); > } > =20 > + fdt_offset =3D fdt_path_offset(fdt, "/"); > + ret =3D spapr_drc_populate_dt(fdt, fdt_offset, NULL, > + SPAPR_DR_CONNECTOR_TYPE_PHB); > + if (ret < 0) { > + fprintf(stderr, "Couldn't set up RTAS device tree properties\n"); This error message isn't right. Otherwise, Reviewed-by: David Gibson > + } > + > _FDT((fdt_pack(fdt))); > =20 > if (fdt_totalsize(fdt) > FDT_MAX_SIZE) { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --WP/lS5xSWAOC+/uo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSKveAAoJEGw4ysog2bOSKAAP/A2Z+FJI3yBq2mu+kRtNR5hS kEXJFl9o58fhbkp6FWxFWlfIIzaL/lfI/NqNav2CVHfIq/zD2Ch4n+FIkBiBG+0a 12KF4FtpHczetwfvFUNA/Rs+diGrWufCxahX/3DWKnPQljV/MZ1v2eWU+qZh6YQz VXBHutdrNm2vnUssXvmnjlud3laOaoT/Amc6UMx5E/bNf5nAdYgZXpAcXK+Kmy8v qgNagP9GZWxDnMKalmXjLPeqThttrE2xfLmdOPEvdZywgDWiWQ8POk7w7SMJNo18 ikWLbak1BAlhrEJIPmoRS5sevuTcYa8oUba4BZ8PyVWkY9/dro3IbjfVssnBEvp4 r6Rved/WBirUsWNVJF9/B0PbmhvIXbcIoISmlXp+D2uMvi8Y2B2DnsROfw9XhMzI mPIT/bjGDHHL5pljyelOI4k6O1mTZSEtakxHZf7tf0qXGgP78+9FkXEz/9MnM8B+ qzszmjiHRpfX7iuJTQWmBSs4VsikR2LU/2NBLk8h481bGQ5CnBZMU6vH0aE0pdNy yr3li+K3y02vYSDKW/Vo1h7PcM3vMV1rHf3B/hNTIkOds8YTopcM6LAL05g3q5g5 /bqtTPCF5152j3GkPN86txyIjyrd1wE2QFTw4S12wtaNp7VwnzoWbaTRakNIKuEz 55u0e5RvwMiO0xzxFxPU =ERVx -----END PGP SIGNATURE----- --WP/lS5xSWAOC+/uo--