From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpZdy-00013W-4h for qemu-devel@nongnu.org; Tue, 05 May 2015 06:00:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpZdu-0000QM-U9 for qemu-devel@nongnu.org; Tue, 05 May 2015 06:00:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpZdu-0000Q8-Pl for qemu-devel@nongnu.org; Tue, 05 May 2015 05:59:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5E2C28E3D0 for ; Tue, 5 May 2015 09:59:58 +0000 (UTC) Date: Tue, 5 May 2015 11:59:50 +0200 From: Thomas Huth Message-ID: <20150505115950.18b35fd7@thh440s> In-Reply-To: <1430818249-12107-1-git-send-email-mrezanin@redhat.com> References: <1430818249-12107-1-git-send-email-mrezanin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrezanin@redhat.com Cc: qemu-devel@nongnu.org On Tue, 5 May 2015 11:30:49 +0200 mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init that is not build. > > Make calling parallel_hds_isa_init depending on CONFIG_PARALLEL so it can > be correctly disabled. > > Signed-off-by: Miroslav Rezanina > --- > hw/i386/pc.c | 2 ++ > hw/mips/mips_fulong2e.c | 2 ++ > hw/mips/mips_malta.c | 2 ++ > hw/sparc64/sun4u.c | 2 ++ > 4 files changed, 8 insertions(+) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index a8e6be1..560464e 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1465,7 +1465,9 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi, > } > > serial_hds_isa_init(isa_bus, MAX_SERIAL_PORTS); > +#ifdef CONFIG_PARALLEL > parallel_hds_isa_init(isa_bus, MAX_PARALLEL_PORTS); > +#endif Not sure, but is this pre-processor macro really defined if CONFIG_PARALLEL has been set in the makefile? I've hit some similar problem in the past and I had to discover that only the CONFIG_* options from config-host.mak get translated into #defines, all the others don't get translated. I might be wrong, but just to be sure, could you please double-check that CONFIG_PARALLEL is #defined if it's enabled in the .mak file? If not: Where does the build break exactly? Does it fail for all three types, i386, mips and sun? Thomas