From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypa9j-0008Cz-KC for qemu-devel@nongnu.org; Tue, 05 May 2015 06:32:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ypa9e-0006AM-GJ for qemu-devel@nongnu.org; Tue, 05 May 2015 06:32:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypa9e-0006A6-3R for qemu-devel@nongnu.org; Tue, 05 May 2015 06:32:46 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t45AWjjs011098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 5 May 2015 06:32:45 -0400 Date: Tue, 5 May 2015 12:32:37 +0200 From: Thomas Huth Message-ID: <20150505123237.2dc75cdf@thh440s> In-Reply-To: <20150505101805.GB2689@lws.brq.redhat.com> References: <1430818249-12107-1-git-send-email-mrezanin@redhat.com> <20150505115950.18b35fd7@thh440s> <20150505101805.GB2689@lws.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miroslav Rezanina Cc: qemu-devel@nongnu.org On Tue, 5 May 2015 12:18:05 +0200 Miroslav Rezanina wrote: > On Tue, May 05, 2015 at 11:59:50AM +0200, Thomas Huth wrote: > > On Tue, 5 May 2015 11:30:49 +0200 > > mrezanin@redhat.com wrote: > > > > > From: Miroslav Rezanina > > > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > > out initialization to parallel_hds_isa_init that is not build. > > > > > > Make calling parallel_hds_isa_init depending on CONFIG_PARALLEL so it can > > > be correctly disabled. > > > > > > Signed-off-by: Miroslav Rezanina > > > --- > > > hw/i386/pc.c | 2 ++ > > > hw/mips/mips_fulong2e.c | 2 ++ > > > hw/mips/mips_malta.c | 2 ++ > > > hw/sparc64/sun4u.c | 2 ++ > > > 4 files changed, 8 insertions(+) > > > > > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > > index a8e6be1..560464e 100644 > > > --- a/hw/i386/pc.c > > > +++ b/hw/i386/pc.c > > > @@ -1465,7 +1465,9 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi, > > > } > > > > > > serial_hds_isa_init(isa_bus, MAX_SERIAL_PORTS); > > > +#ifdef CONFIG_PARALLEL > > > parallel_hds_isa_init(isa_bus, MAX_PARALLEL_PORTS); > > > +#endif > > > > Not sure, but is this pre-processor macro really defined if > > CONFIG_PARALLEL has been set in the makefile? I've hit some similar > > problem in the past and I had to discover that only the CONFIG_* > > options from config-host.mak get translated into #defines, all the > > others don't get translated. I might be wrong, but just to be sure, > > could you please double-check that CONFIG_PARALLEL is #defined if it's > > enabled in the .mak file? > > > > Yeah, you're right..I switch the behavior so thought of CONFIG_* from > config-host.mak to be the one to not translated. And ifdef masked the > issue. > > This patch is not working and has to be redone. > > > If not: Where does the build break exactly? Does it fail for all three > > types, i386, mips and sun? > > > > I can't test mips/sun build but for i386 it fails on linking where > parallel_hds_isa_init does not exists. That's strange, there is a CONFIG_PARALLEL=y in both, default-configs/x86_64-softmmu.mak and i386-softmmu.mak so I wonder why the parallel.o object file is not linked in your case? Thomas