From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Ypdq4-0007bg-Dr
	for qemu-devel@nongnu.org; Tue, 05 May 2015 10:28:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Ypdq1-0002gz-1Y
	for qemu-devel@nongnu.org; Tue, 05 May 2015 10:28:48 -0400
Date: Tue, 5 May 2015 16:28:33 +0200
From: Thomas Huth <thuth@redhat.com>
Message-ID: <20150505162833.3d0141e2@thh440s>
In-Reply-To: <1430816036-26408-3-git-send-email-nikunj@linux.vnet.ibm.com>
References: <1430816036-26408-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<1430816036-26408-3-git-send-email-nikunj@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit
 memory address space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au

On Tue,  5 May 2015 14:23:52 +0530
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> wrote:

> The properties reg/assigned-resources need to encode 64-bit memory
> address space as part of phys.hi dword.
> 
>   00 if configuration space
>   01 if IO region,
>   10 if 32-bit MEM region
>   11 if 64-bit MEM region
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
>  hw/ppc/spapr_pci.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 4df3a33..ea1a092 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -786,7 +786,13 @@ typedef struct ResourceProps {
>   * phys.hi = 0xYYXXXXZZ, where:
>   *   0xYY = npt000ss
>   *          |||   |
> - *          |||   +-- space code: 1 if IO region, 2 if MEM region
> + *          |||   +-- space code
> + *          |||               |
> + *          |||               +  00 if configuration space
> + *          |||               +  01 if IO region,
> + *          |||               +  10 if 32-bit MEM region
> + *          |||               +  11 if 64-bit MEM region
> + *          |||
>   *          ||+------ for non-relocatable IO: 1 if aliased
>   *          ||        for relocatable IO: 1 if below 64KB
>   *          ||        for MEM: 1 if below 1MB
> @@ -846,6 +852,8 @@ static void populate_resource_props(PCIDevice *d, ResourceProps *rp)
>          reg->phys_hi = cpu_to_be32(dev_id | b_rrrrrrrr(pci_bar(d, i)));
>          if (d->io_regions[i].type & PCI_BASE_ADDRESS_SPACE_IO) {
>              reg->phys_hi |= cpu_to_be32(b_ss(1));
> +        } else if (d->io_regions[i].type & PCI_BASE_ADDRESS_MEM_TYPE_64) {
> +            reg->phys_hi |= cpu_to_be32(b_ss(3));
>          } else {
>              reg->phys_hi |= cpu_to_be32(b_ss(2));
>          }

Reviewed-by: Thomas Huth <thuth@redhat.com>

BTW, does this also require the new version of SLOF already?