From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpuEX-0003ry-5R for qemu-devel@nongnu.org; Wed, 06 May 2015 03:59:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpuET-00064f-U0 for qemu-devel@nongnu.org; Wed, 06 May 2015 03:59:09 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:37541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpuET-000631-91 for qemu-devel@nongnu.org; Wed, 06 May 2015 03:59:05 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 13:29:02 +0530 Date: Wed, 6 May 2015 13:28:56 +0530 From: Bharata B Rao Message-ID: <20150506075856.GR18380@in.ibm.com> References: <1429858066-12088-1-git-send-email-bharata@linux.vnet.ibm.com> <1429858066-12088-22-git-send-email-bharata@linux.vnet.ibm.com> <20150505073333.GR14090@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150505073333.GR14090@voom.redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de On Tue, May 05, 2015 at 05:33:33PM +1000, David Gibson wrote: > On Fri, Apr 24, 2015 at 12:17:43PM +0530, Bharata B Rao wrote: > > Initialize a hotplug memory region under which all the hotplugged > > memory is accommodated. Also enable memory hotplug by setting > > CONFIG_MEM_HOTPLUG. > > > > Modelled on i386 memory hotplug. > > > > Signed-off-by: Bharata B Rao > > So, the cpu hotplug stuff has been caught up in these generic level > design discussions. Could you split out the memory hotplug part of > this series so that we might be able to move forwards with that while > the cpu hotplug discussion continues? Yes, in fact I too was planning to split memory and push it separately. > > > --- > > default-configs/ppc64-softmmu.mak | 1 + > > hw/ppc/spapr.c | 38 ++++++++++++++++++++++++++++++++++++++ > > include/hw/ppc/spapr.h | 12 ++++++++++++ > > 3 files changed, 51 insertions(+) > > > > diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak > > index 22ef132..16b3011 100644 > > --- a/default-configs/ppc64-softmmu.mak > > +++ b/default-configs/ppc64-softmmu.mak > > @@ -51,3 +51,4 @@ CONFIG_XICS_KVM=$(and $(CONFIG_PSERIES),$(CONFIG_KVM)) > > # For PReP > > CONFIG_MC146818RTC=y > > CONFIG_ISA_TESTDEV=y > > +CONFIG_MEM_HOTPLUG=y > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 910a50f..9dc4c36 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -125,6 +125,9 @@ struct sPAPRMachineState { > > > > /*< public >*/ > > char *kvm_type; > > + ram_addr_t hotplug_memory_base; > > + MemoryRegion hotplug_memory; > > + bool enforce_aligned_dimm; > > As mentioned on the earlier version, on ppc we don't have > compatibility reasons we need to have a mode for unaligned dimms. Get > rid of this bool and treat it as always on instead. ok. Regards, Bharata.