From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YptpP-0000mH-FM for qemu-devel@nongnu.org; Wed, 06 May 2015 03:33:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YptpK-0005cv-7K for qemu-devel@nongnu.org; Wed, 06 May 2015 03:33:11 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:57693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YptpJ-0005cF-UU for qemu-devel@nongnu.org; Wed, 06 May 2015 03:33:06 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 08:33:03 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id A2BB12190056 for ; Wed, 6 May 2015 08:32:42 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t467X0OQ7012624 for ; Wed, 6 May 2015 07:33:00 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t462R4jN001820 for ; Tue, 5 May 2015 22:27:05 -0400 Date: Wed, 6 May 2015 09:32:58 +0200 From: Michael Mueller Message-ID: <20150506093258.423d56c3@bee> In-Reply-To: <20150505131432.GP17796@thinpad.lan.raisama.net> References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com> <1430146411-34632-5-git-send-email-mimu@linux.vnet.ibm.com> <20150505131432.GP17796@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Cornelia Huck , Gleb Natapov , qemu-devel@nongnu.org, Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Luiz Capitulino , Andreas Faerber , Richard Henderson On Tue, 5 May 2015 10:14:32 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > The HMP command info cpus now displays the CPU model name and the > > backing accelerator if part of the CPUState. > > > > (qemu) info cpus > > * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 > > > > Signed-off-by: Michael Mueller > > Acked-by: Christian Borntraeger > > Do we really need this? I mean: I expect the amount of CPU data we > provide to QMP clients to grow a lot in the near future, but that > doesn't mean HMP users need all that data to be printed by "info cpus". Where do you see the limit of what is worth to be shown an what not. I personally use "info cpus" less then sporadic but already got a comment internally on that information being worthwhile to be shown. > > > > --- > > hmp.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/hmp.c b/hmp.c > > index f142d36..676d821 100644 > > --- a/hmp.c > > +++ b/hmp.c > > @@ -290,6 +290,13 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) > > monitor_printf(mon, " (halted)"); > > } > > > > + if (cpu->value->has_model) { > > + monitor_printf(mon, " model=%s", cpu->value->model); > > + } > > + if (cpu->value->has_accel) { > > + monitor_printf(mon, " accel=%s", AccelId_lookup[cpu->value->accel]); > > + } > > + > > monitor_printf(mon, " thread_id=%" PRId64 "\n", cpu->value->thread_id); > > } > > > > -- > > 1.8.3.1 > > >