From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Gleb Natapov <gleb@kernel.org>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
Daniel Hansel <daniel.hansel@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andreas Faerber <afaerber@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState
Date: Wed, 6 May 2015 11:28:17 +0200 [thread overview]
Message-ID: <20150506112817.6d6aafb6@bee> (raw)
In-Reply-To: <20150505144604.GU17796@thinpad.lan.raisama.net>
On Tue, 5 May 2015 11:46:04 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Tue, May 05, 2015 at 08:36:45AM -0600, Eric Blake wrote:
> > On 05/05/2015 07:26 AM, Eduardo Habkost wrote:
> > >> +{ 'enum': 'AccelId',
> > >> + 'data': ['qtest', 'tcg', 'kvm', 'xen'] }
> > >> +
> > >
> > > Not sure if it is better to have an enum or simply a string here.
> >
> > enum is almost always better when there is a finite set of possible
> > strings - it's better documented, and when introspection is in place,
> > will make it easier to determine when the set has grown.
>
> True, and there are other cases where we could use an enum internally in
> QEMU (e.g. arrays for accelerator-specific data inside CPU classes).
Actually the accelerator name currently represented as string (ac->name = "KVM";)
can be initialized from the respective lookup value (AccelId_lookup[]) instead.
>
next prev parent reply other threads:[~2015-05-06 9:28 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 14:53 [Qemu-devel] [PATCH v6 00/17] s390 cpu model implementation Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail Michael Mueller
2015-05-05 13:55 ` Eduardo Habkost
2015-05-05 16:12 ` Michael Mueller
2015-05-05 17:41 ` Eduardo Habkost
2015-05-06 9:17 ` Michael Mueller
2015-05-06 11:23 ` Eduardo Habkost
2015-05-06 16:23 ` Michael Mueller
2015-05-06 17:06 ` Eduardo Habkost
2015-05-07 7:35 ` Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState Michael Mueller
2015-05-05 13:26 ` Eduardo Habkost
2015-05-05 14:36 ` Eric Blake
2015-05-05 14:46 ` Eduardo Habkost
2015-05-06 9:28 ` Michael Mueller [this message]
2015-05-06 9:59 ` Michael Mueller
2015-05-06 11:41 ` Eduardo Habkost
2015-05-07 7:55 ` Michael Mueller
2015-05-07 15:04 ` Eduardo Habkost
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name Michael Mueller
2015-05-05 13:11 ` Eduardo Habkost
2015-05-06 9:49 ` Michael Mueller
2015-05-06 11:33 ` Eduardo Habkost
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display " Michael Mueller
2015-05-05 13:14 ` Eduardo Habkost
2015-05-06 7:32 ` Michael Mueller
2015-05-06 10:38 ` Eduardo Habkost
2015-05-06 12:59 ` Luiz Capitulino
2015-05-06 13:33 ` Eduardo Habkost
2015-05-06 13:44 ` Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions Michael Mueller
2015-05-06 12:42 ` Eduardo Habkost
2015-05-07 7:37 ` Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 06/17] target-s390x: Introduce S390 CPU facilities Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 07/17] target-s390x: Generate facility defines per S390 CPU model Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 08/17] target-s390x: Introduce S390 CPU models Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 09/17] target-s390x: Define S390 CPU model specific facility lists Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 10/17] target-s390x: Add S390 CPU model alias definition routines Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines Michael Mueller
2015-05-05 14:34 ` Eduardo Habkost
2015-05-06 8:02 ` Michael Mueller
2015-05-06 12:20 ` Eduardo Habkost
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 13/17] target-s390x: Prepare accelerator during S390 CPU object realization Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 14/17] target-s390x: Initialize S390 CPU model name in CPUState Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions Michael Mueller
2015-05-05 18:40 ` Eduardo Habkost
2015-05-06 15:31 ` Michael Mueller
2015-05-06 16:00 ` Eduardo Habkost
2015-05-06 16:27 ` Michael Mueller
2015-05-06 12:37 ` Eduardo Habkost
2015-05-06 14:48 ` Michael Mueller
2015-05-11 16:59 ` Eduardo Habkost
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 16/17] target-s390x: Introduce S390 CPU facility test routine Michael Mueller
2015-04-27 14:53 ` [Qemu-devel] [PATCH v6 17/17] target-s390x: Enable S390 CPU model usage Michael Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506112817.6d6aafb6@bee \
--to=mimu@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=daniel.hansel@linux.vnet.ibm.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=jjherne@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).