From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypvxq-0003Rn-VB for qemu-devel@nongnu.org; Wed, 06 May 2015 05:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ypvxn-0001VT-LO for qemu-devel@nongnu.org; Wed, 06 May 2015 05:50:02 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:44084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypvxn-0001Ui-Bl for qemu-devel@nongnu.org; Wed, 06 May 2015 05:49:59 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 10:49:56 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 34DF12190046 for ; Wed, 6 May 2015 10:49:36 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t469ns7M43188428 for ; Wed, 6 May 2015 09:49:54 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t469nqWq010658 for ; Wed, 6 May 2015 03:49:53 -0600 Date: Wed, 6 May 2015 11:49:50 +0200 From: Michael Mueller Message-ID: <20150506114950.7ecc324d@bee> In-Reply-To: <20150505131115.GO17796@thinpad.lan.raisama.net> References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com> <1430146411-34632-4-git-send-email-mimu@linux.vnet.ibm.com> <20150505131115.GO17796@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Cornelia Huck , Gleb Natapov , qemu-devel@nongnu.org, Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Andreas Faerber , Richard Henderson On Tue, 5 May 2015 10:11:15 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote: > > The QMP command query-cpus now additionally displays a model name and > > the backing accelerator. Both are omitted if the model name is not > > initialized. > > > > request: > > { "execute" : "query-cpus" } > > > > answer: > > { { "current": true, > > "CPU": 0, > > "model": "2827-ga2", > > "halted": false, > > "accel": "kvm", > > "thread_id": 31917 > > }, ... } > > > > Signed-off-by: Michael Mueller > > Acked-by: Christian Borntraeger > > With the new qom-path field I submitted yesterday, this can be provided > as QOM properties through qom-get. Is that really a good idea to make the object representation part of the ABI. I guess there is a related discussion already somewhere. I mean not just adding the qom-path field, I saw that suggested patch, I mean the approach to expose the objects themselves... I will try your patch of course as well... Michael >