From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypzd6-0006sJ-7R for qemu-devel@nongnu.org; Wed, 06 May 2015 09:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ypzd0-0003BF-NR for qemu-devel@nongnu.org; Wed, 06 May 2015 09:44:52 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:47578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypzd0-0003Ar-D3 for qemu-devel@nongnu.org; Wed, 06 May 2015 09:44:46 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 14:44:44 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6B6CE1B08070 for ; Wed, 6 May 2015 14:45:25 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t46DigPM6095214 for ; Wed, 6 May 2015 13:44:42 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t46Dif5B031226 for ; Wed, 6 May 2015 07:44:42 -0600 Date: Wed, 6 May 2015 15:44:39 +0200 From: Michael Mueller Message-ID: <20150506154439.3e151cb1@bee> In-Reply-To: <20150506133355.GD17796@thinpad.lan.raisama.net> References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com> <1430146411-34632-5-git-send-email-mimu@linux.vnet.ibm.com> <20150505131432.GP17796@thinpad.lan.raisama.net> <20150506093258.423d56c3@bee> <20150506103853.GY17796@thinpad.lan.raisama.net> <20150506085956.6c7df07b@redhat.com> <20150506133355.GD17796@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Cornelia Huck , Gleb Natapov , Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Luiz Capitulino , Andreas Faerber , Richard Henderson On Wed, 6 May 2015 10:33:55 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 08:59:56AM -0400, Luiz Capitulino wrote: > > On Wed, 6 May 2015 07:38:53 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > > > > On Tue, 5 May 2015 10:14:32 -0300 > > > > Eduardo Habkost wrote: > > > > > > > > > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > > > > > The HMP command info cpus now displays the CPU model name and the > > > > > > backing accelerator if part of the CPUState. > > > > > > > > > > > > (qemu) info cpus > > > > > > * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 > > > > > > > > > > > > Signed-off-by: Michael Mueller > > > > > > Acked-by: Christian Borntraeger > > > > > > > > > > Do we really need this? I mean: I expect the amount of CPU data we > > > > > provide to QMP clients to grow a lot in the near future, but that > > > > > doesn't mean HMP users need all that data to be printed by "info cpus". > > > > > > > > Where do you see the limit of what is worth to be shown an what not. > > > > I personally use "info cpus" less then sporadic but already got a comment > > > > internally on that information being worthwhile to be shown. > > > > > > I really don't know, but I think we shouldn't add stuff to HMP unless we > > > have a good reason. For each new piece of data in HMP I would like to at > > > least see the description of a real use case that justifies adding it to > > > HMP and not just implementing a simple script on top of QMP. > > > > > > For accel info we already have "info kvm" that is not ideal but is > > > enough for current use cases, isn't it? CPU model name information seems > > > to be more useful, but if it is just for debugging, people can just run > > > QMP query-cpus command. > > > > > > Luiz, what do you think? > > > > I don't see a problem with that. HMP is a debugging interface anyways. > > Actually, I think it's a good test-case for QMP having a high-level > > in-tree client (vs. qmp-shell, which is too low-level). > > > > If the problem is that a command is dumping too much information to > > the point of hurting usability, we can split the command or add a '-a' > > option or something like that. > > Thanks! If HMP is seen as a debugging interface, my main objections > aren't valid. > > That said, I would prefer to keep the command output cleaner and add > only the "model" field, as people can use "info kvm" for the accel info > by now. Ok, I buy that and will kick the accel name out again. Michael >