From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq2AE-0000hY-Oo for qemu-devel@nongnu.org; Wed, 06 May 2015 12:27:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq2AB-0006sJ-Br for qemu-devel@nongnu.org; Wed, 06 May 2015 12:27:14 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:51723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq2AB-0006s8-2h for qemu-devel@nongnu.org; Wed, 06 May 2015 12:27:11 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 May 2015 17:27:10 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B042B17D805A for ; Wed, 6 May 2015 17:27:51 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t46GR66i1114508 for ; Wed, 6 May 2015 16:27:06 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t46BLApU013422 for ; Wed, 6 May 2015 07:21:10 -0400 Date: Wed, 6 May 2015 18:27:03 +0200 From: Michael Mueller Message-ID: <20150506182703.0febbaaf@bee> In-Reply-To: <20150506160032.GE17796@thinpad.lan.raisama.net> References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com> <1430146411-34632-16-git-send-email-mimu@linux.vnet.ibm.com> <20150505184034.GW17796@thinpad.lan.raisama.net> <20150506173106.7bf7262f@bee> <20150506160032.GE17796@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Gleb Natapov , qemu-devel@nongnu.org, Alexander Graf , Christian Borntraeger , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson On Wed, 6 May 2015 13:00:32 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 05:31:06PM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 15:40:34 -0300 > > Eduardo Habkost wrote: > [...] > > > Second, you shouldn't even need to duplicate code in > > > get_machine_props_fallback() if you are able to create an accel object > > > and do just basic initialization so that cpu_model_get() works. > > > Allowing accel objects to be created on the fly was one of the main > > > purposes of the accel QOM work. > > > > > > For example, if we do something like this: > > > https://github.com/ehabkost/qemu-hacks/commit/36a250e34c5fd0d43a25271f5bc9b04681fdd56a [1] > > > https://github.com/ehabkost/qemu-hacks/commits/work/accel-open-func > > > > I had a look at your qemu-hacks before writing the _fallback() routine > > but did not wanted to base on some not yet published code. Once your part goes > > upstream my intend is to provide a cleanup patch... And I was missing the > > KVM_CREATE_VM actually. > > No problem to me if you prefer to keep it this way and change it to use > AccelState as a follow-up, after appropriate methods are provided by > TYPE_KVM_ACCEL. Your patch was helpful to show that just extracting the > open("/dev/kvm") part isn't enough and more work is needed. promised :-) >