From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqAg7-0005pt-HN for qemu-devel@nongnu.org; Wed, 06 May 2015 21:32:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqAg3-0005zb-HO for qemu-devel@nongnu.org; Wed, 06 May 2015 21:32:43 -0400 Date: Thu, 7 May 2015 11:07:50 +1000 From: David Gibson Message-ID: <20150507010750.GG1407@voom.redhat.com> References: <1429858066-12088-1-git-send-email-bharata@linux.vnet.ibm.com> <1429858066-12088-19-git-send-email-bharata@linux.vnet.ibm.com> <20150505072252.GP14090@voom.redhat.com> <20150506054200.GN18380@in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Cp3Cp8fzgozWLBWL" Content-Disposition: inline In-Reply-To: <20150506054200.GN18380@in.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v3 18/24] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de --Cp3Cp8fzgozWLBWL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2015 at 11:12:00AM +0530, Bharata B Rao wrote: > On Tue, May 05, 2015 at 05:22:52PM +1000, David Gibson wrote: > > On Fri, Apr 24, 2015 at 12:17:40PM +0530, Bharata B Rao wrote: > > > When supporting CPU hot removal by parking the vCPU fd and reusing > > > it during hotplug again, there can be cases where we try to reenable > > > KVM_CAP_IRQ_XICS CAP for the vCPU for which it was already enabled. > > > Introduce a boolean member in ICPState to track this and don't > > > reenable the CAP if it was already enabled earlier. > > >=20 > > > This change allows CPU hot removal to work for sPAPR. > > >=20 > > > Signed-off-by: Bharata B Rao > >=20 > > Do you actually need this? Is there any harm in setting the > > capability multiple times, or could you just ignore the "already set" > > error? >=20 > We discussed this last time and concluded that this patch is needed. >=20 > Ref: http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg05361.html Ah, ok. Can you include the explanation from that message into the commit message so I don't forget next time (and for the benefit of other reviewers). --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Cp3Cp8fzgozWLBWL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSrrmAAoJEGw4ysog2bOSvP4P/1UHAqoP9ZwtYI7Heam9touj LDhqAFFpams+i9olgeAVDVMcGr+oy/Q6oK16N2OsdEnQAk+2qs/JOUEb6VZPTNLQ pMuYsjKxnsoy3gCtnyGXj2n4By67g4h3Mohpw9XYR/EHyL0c1hA8bTnC5vIRg0oE oq5fZK/EzbscXk+T4yJt2Rlpnebn3GxkuntPcX+T+OCc4ML7MNDKY6qoTnQ9BLNP Ooqt2DhRIIoYyWeY5EfBXBDqqidJdt2UpW825vziR9GoKBZgS8IOA1BgcjItJSVQ M2NB+pupKTPjkdV+L05Rrtup0xjeMnP9Xe280be1SGtztqHg3BH6nzTXdY1zTNnY Q7yvXnA/r9H2Da8+h3zJ0KxfN/YD6WWTijBBUslTZe9lmSRkAjF0Y+TJtE8VsWty DQfiLFKXB+DPwgROu721A5I7FxrAYWmS39QdVEmk/p4dnnFKVxhD9KvvvwPz+9RU pVE0Beh717QYUL2psEjHYkf2KOxcp5F12CEbznCJU1nkkUwUDdWcom5Oce3hWzte qDMpj81j/tTZr/VVUeBQGkxsIUSBn4HR/Cq9ka8s85MvzgUb6H0Xtg2CwznOW8js 0JcYrAXH1efR0M3NkTv3Cy/+yfLg5oYsuRXe8A3Qu+eZecD6g26ZHHNeAGDk+Khf OQGKjaWtV6cvj7U2dgkZ =WFrF -----END PGP SIGNATURE----- --Cp3Cp8fzgozWLBWL--