From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqGMv-0005M2-IM for qemu-devel@nongnu.org; Thu, 07 May 2015 03:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqGMp-0004lT-1D for qemu-devel@nongnu.org; Thu, 07 May 2015 03:37:17 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:45278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqGMo-0004lF-Mj for qemu-devel@nongnu.org; Thu, 07 May 2015 03:37:10 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 May 2015 08:37:09 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8D5C81B0805F for ; Thu, 7 May 2015 08:37:50 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t477b7Ll1442184 for ; Thu, 7 May 2015 07:37:07 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t477b6iw019896 for ; Thu, 7 May 2015 01:37:07 -0600 Date: Thu, 7 May 2015 09:37:04 +0200 From: Michael Mueller Message-ID: <20150507093704.138b582e@bee> In-Reply-To: <20150506124226.GI25766@thinpad.lan.raisama.net> References: <1430146411-34632-1-git-send-email-mimu@linux.vnet.ibm.com> <1430146411-34632-6-git-send-email-mimu@linux.vnet.ibm.com> <20150506124226.GI25766@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Cornelia Huck , Gleb Natapov , qemu-devel@nongnu.org, Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Daniel Hansel , Paolo Bonzini , Andreas Faerber , Richard Henderson On Wed, 6 May 2015 09:42:26 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:19PM +0200, Michael Mueller wrote: > [...] > > diff --git a/qapi-schema.json b/qapi-schema.json > > index 215a7bc..285b2d3 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -2536,21 +2536,43 @@ > > # > > # @name: the name of the CPU definition > > # > > +# @default: #optional true if cpu model is the default, > > +# omitted if false (since 2.4) > > Maybe we should clarify that it is the default in the machine provided > as argument to query-cpu-definitions? > > > +# > > +# @runnable: #optional true if cpu model is runnable, > > +# omitted if false (since 2.4) > > Maybe we should clarify that it means the CPU model is runnable using > the machine+accel combination provided as arguments to > query-cpu-definitions? I will extend the comments accordingly. > > (See also my question about the meaning of runnable when machine is > omitted, in my reply to patch 15/17). > > > +# > > +# @live-migration-safe: #optional true if cpu model represents a > > +# cpu model that is safely migratable > > +# omitted if false (since 2.4) > > +# > > +# @order: #optional order criterion > > +# > > # Since: 1.2.0 > > ## > > { 'type': 'CpuDefinitionInfo', > > - 'data': { 'name': 'str' } } > > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool', > > + '*live-migration-safe': 'bool', '*order': 'int' } } > > > > ## > > # @query-cpu-definitions: > > # > > -# Return a list of supported virtual CPU definitions > > +# Return a list of supported virtual CPU definitions. In context with the > > +# optional parameters @machine and @accel the returned list contains > > +# also information if the respective cpu definition is runnable or the > > +# default to be used. > > +# > > +# @machine: #optional machine type (since 2.4) > > +# > > +# @accel: #optional accelerator id (since 2.4) > > # > > # Returns: a list of CpuDefInfo > > # > > # Since: 1.2.0 > > ## > > -{ 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'] } > > +{ 'command': 'query-cpu-definitions', > > + 'data': { '*machine': 'str', '*accel': 'AccelId' }, > > + 'returns': ['CpuDefinitionInfo'] } > > >