From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqIkn-0004LQ-Bs for qemu-devel@nongnu.org; Thu, 07 May 2015 06:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqIkg-0000j7-JQ for qemu-devel@nongnu.org; Thu, 07 May 2015 06:10:05 -0400 Date: Thu, 7 May 2015 11:09:54 +0100 From: Stefan Hajnoczi Message-ID: <20150507100954.GD13985@stefanha-thinkpad.redhat.com> References: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2iBwrppp/7QCDedR" Content-Disposition: inline In-Reply-To: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhe Qiu Cc: Kevin Wolf , Stefan Weil , qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com --2iBwrppp/7QCDedR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 07, 2015 at 12:04:56PM +0800, Zhe Qiu wrote: > From: phoeagon >=20 > In reference to b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b0d= b262c4b05fee51d01de2d1d2, metadata writes to qcow2/cow/qcow/vpc/vmdk are al= l synced prior to succeeding writes. >=20 > Only when write is successful that bdrv_flush is called. >=20 > Signed-off-by: Zhe Qiu > --- > block/vdi.c | 3 +++ > 1 file changed, 3 insertions(+) CCing Stefan Weil and Kevin Wolf (see output from scripts/get_maintainer.pl -f block/vdi.c). >=20 > diff --git a/block/vdi.c b/block/vdi.c > index 7642ef3..dfe8ade 100644 > --- a/block/vdi.c > +++ b/block/vdi.c > @@ -713,6 +713,9 @@ static int vdi_co_write(BlockDriverState *bs, > logout("will write %u block map sectors starting from entry %u\n= ", > n_sectors, bmap_first); > ret =3D bdrv_write(bs->file, offset, base, n_sectors); > + if (ret >=3D 0) { > + ret =3D bdrv_flush(bs->file); > + } > } > =20 > return ret; > --=20 > 2.4.0 >=20 >=20 --2iBwrppp/7QCDedR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVSznyAAoJEJykq7OBq3PI5t0IALH31tfu1YTjXBZLZJajy6P4 C8j738Hb3vgvmDQH5HXyPoDNutpV+o2F7vuee6SPlltURVv7YX0N9IBse84ZuC6H egQn3GzsWQgLk4emVON+68L9JwwsDbURNt6l9RD3wMVPFGnlfpBODhmIRRXk7rCG ZmEuQz67tvU/pLUeEarZu2BTlyXe687atfkYuUloW3WARuvd/uMjJbKoNRppDJAQ vAm3hgwNiC2ljygoYEZjykQtdiZ9/rGW+UV5PAQjog7jPwzzXDj+zvNkyh4cuH0E sQErIn9GcCBu3C3Ihwc2K8I3bLOlp5KxY9iKZUxHdCAdL0AeZqFBMXRdO7txMGQ= =2Gkp -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR--