From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function
Date: Thu, 7 May 2015 11:20:23 +0100 [thread overview]
Message-ID: <20150507102023.GJ13985@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <4df51e8786b8f313066bf0d29ae4aa321a8960a8.1430919406.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Wed, May 06, 2015 at 04:39:30PM +0300, Alberto Garcia wrote:
> This function never receives an invalid table pointer, so we can make
> it void and remove all the error checking code.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2-cache.c | 7 +------
> block/qcow2-cluster.c | 50 ++++++++++----------------------------------------
> block/qcow2-refcount.c | 29 +++++------------------------
> block/qcow2.h | 2 +-
> 4 files changed, 17 insertions(+), 71 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-07 10:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 13:39 [Qemu-devel] [PATCH v2 0/7] qcow2 L2/refcount cache improvements Alberto Garcia
2015-05-06 13:39 ` [Qemu-devel] [PATCH 1/7] qcow2: use one single memory block for the L2/refcount cache tables Alberto Garcia
2015-05-07 10:14 ` Stefan Hajnoczi
2015-05-08 15:03 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-06 13:39 ` [Qemu-devel] [PATCH 2/7] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty() Alberto Garcia
2015-05-07 10:15 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-08 15:12 ` Max Reitz
2015-05-06 13:39 ` [Qemu-devel] [PATCH 3/7] qcow2: use an LRU algorithm to replace entries from the L2 cache Alberto Garcia
2015-05-07 10:16 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-07 14:55 ` [Qemu-devel] " Eric Blake
2015-05-07 15:01 ` Alberto Garcia
2015-05-08 15:22 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-06 13:39 ` [Qemu-devel] [PATCH 4/7] qcow2: remove qcow2_cache_find_entry_to_replace() Alberto Garcia
2015-05-07 10:17 ` Stefan Hajnoczi
2015-05-08 15:27 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-06 13:39 ` [Qemu-devel] [PATCH 5/7] qcow2: use a hash to look for entries in the L2 cache Alberto Garcia
2015-05-07 10:18 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-08 15:46 ` Max Reitz
2015-05-08 16:48 ` Alberto Garcia
2015-05-06 13:39 ` [Qemu-devel] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function Alberto Garcia
2015-05-07 10:20 ` Stefan Hajnoczi [this message]
2015-05-08 15:51 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-08 16:59 ` Alberto Garcia
2015-05-06 13:39 ` [Qemu-devel] [PATCH 7/7] qcow2: style fixes in qcow2-cache.c Alberto Garcia
2015-05-07 10:20 ` Stefan Hajnoczi
2015-05-08 15:52 ` [Qemu-devel] [Qemu-block] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507102023.GJ13985@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).