From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YqIuu-0002nn-3T
	for qemu-devel@nongnu.org; Thu, 07 May 2015 06:20:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YqIuo-0006Vt-MH
	for qemu-devel@nongnu.org; Thu, 07 May 2015 06:20:32 -0400
Date: Thu, 7 May 2015 11:20:23 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150507102023.GJ13985@stefanha-thinkpad.redhat.com>
References: <cover.1430919406.git.berto@igalia.com>
	<4df51e8786b8f313066bf0d29ae4aa321a8960a8.1430919406.git.berto@igalia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="va4/JQ6j8/8uipEp"
Content-Disposition: inline
In-Reply-To: <4df51e8786b8f313066bf0d29ae4aa321a8960a8.1430919406.git.berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH 6/7] qcow2: make qcow2_cache_put() a void
 function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org


--va4/JQ6j8/8uipEp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 06, 2015 at 04:39:30PM +0300, Alberto Garcia wrote:
> This function never receives an invalid table pointer, so we can make
> it void and remove all the error checking code.
>=20
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/qcow2-cache.c    |  7 +------
>  block/qcow2-cluster.c  | 50 ++++++++++----------------------------------=
------
>  block/qcow2-refcount.c | 29 +++++------------------------
>  block/qcow2.h          |  2 +-
>  4 files changed, 17 insertions(+), 71 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--va4/JQ6j8/8uipEp
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVSzxnAAoJEJykq7OBq3PIUyoIALRU05mxIOGCgi1e8Ho6q/0B
FPbEvnqMKVZ2JC9p3PvHM6OmolsfHaNJoAQVvNZemsnzdcLTXX07ZumIvBwNg9AU
kxTDDCN0Kom8NoNxdaoNyN/VrIDkG0jd1yQJv0glqmZsvY8hnU4u9hBzdFm8Gj2/
B7KRVECxFKkD2GwXpCPEQk7uwl7XriZkQsMQYWeFETCY1EBgvGvQgvuGJ0yvoFgA
E2NUhaNJNbyFWE2vCfsBkIO/DVP4VIN+GAkPpZlr27mZsUyi0AC24AQKk9vBXwdu
Lh+67/wIQ5kyA1rxoz9HWw/vgGsIcZDbrS+sloOVYMleaWNExIw5fbsVxPCY1Uk=
=YdNI
-----END PGP SIGNATURE-----

--va4/JQ6j8/8uipEp--