From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqK8E-0000Id-HE for qemu-devel@nongnu.org; Thu, 07 May 2015 07:38:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqK8A-0002jm-KK for qemu-devel@nongnu.org; Thu, 07 May 2015 07:38:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqK8A-0002je-Fl for qemu-devel@nongnu.org; Thu, 07 May 2015 07:38:18 -0400 Date: Thu, 7 May 2015 12:38:13 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150507113813.GE2139@work-vm> References: <1431023482-9044-1-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431023482-9044-1-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [PATCH] migration: Fix migration state update issue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: amit.shah@redhat.com, yang.z.zhang@intel.com, qemu-devel@nongnu.org, quintela@redhat.com * Liang Li (liang.z.li@intel.com) wrote: > If live migration is very fast and can be completed in 1 second, > the dirty_sync_count of MigrationState will not be updated. > Then you will see "dirty sync count: 0" in qemu monitor even if > the actual dirty sync count is not 0. > > Signed-off-by: Liang Li > --- > arch_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch_init.c b/arch_init.c > index 4c8fcee..a48f575 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -599,8 +599,8 @@ static void migration_bitmap_sync(void) > s->dirty_bytes_rate = s->dirty_pages_rate * TARGET_PAGE_SIZE; > start_time = end_time; > num_dirty_pages_period = 0; > - s->dirty_sync_count = bitmap_sync_count; > } > + s->dirty_sync_count = bitmap_sync_count; > } Yes, makes sense. (An interesting question is why there needs to be a separate bitmap_sync_count variable that's separate from s->dirty_sync_count) Reviewed-by: Dr. David Alan Gilbert Dave > > /** > -- > 1.9.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK