From: Kevin Wolf <kwolf@redhat.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature
Date: Thu, 7 May 2015 15:51:11 +0200 [thread overview]
Message-ID: <20150507135111.GD4571@noname.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1504301359170.15930@localhost.lm.intel.com>
[ Cc: qemu-block ]
Am 30.04.2015 um 16:03 hat Keith Busch geschrieben:
> On Thu, 30 Apr 2015, Christoph Hellwig wrote:
> >The SCSI emulation in the Linux NVMe driver really wants to know
> >if a device has a volatile write cache. Given that qemu has moved
> >away from a model where we report the backing store WCE bit to
> >one where the WCE bit is supposed to be part of the migratable
> >guest-visible state we always return 1 here.
>
> Thanks, this fix was long overdue and already incorporated in my tree. I
> really need to get my act together for a legit pull request with all the
> other 1.0, 1.1 and 1.2 features.
>
> Acked-by: Keith Busch <keith.busch@intel.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-05-07 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 9:44 [Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature Christoph Hellwig
2015-04-30 14:03 ` Keith Busch
2015-05-07 13:51 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507135111.GD4571@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).