From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqMCx-0007eo-76 for qemu-devel@nongnu.org; Thu, 07 May 2015 09:51:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqMCt-0000N2-T6 for qemu-devel@nongnu.org; Thu, 07 May 2015 09:51:23 -0400 Date: Thu, 7 May 2015 15:51:11 +0200 From: Kevin Wolf Message-ID: <20150507135111.GD4571@noname.redhat.com> References: <20150430094417.GA18671@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Keith Busch Cc: Christoph Hellwig , qemu-block@nongnu.org, qemu-devel@nongnu.org [ Cc: qemu-block ] Am 30.04.2015 um 16:03 hat Keith Busch geschrieben: > On Thu, 30 Apr 2015, Christoph Hellwig wrote: > >The SCSI emulation in the Linux NVMe driver really wants to know > >if a device has a volatile write cache. Given that qemu has moved > >away from a model where we report the backing store WCE bit to > >one where the WCE bit is supposed to be part of the migratable > >guest-visible state we always return 1 here. > > Thanks, this fix was long overdue and already incorporated in my tree. I > really need to get my act together for a legit pull request with all the > other 1.0, 1.1 and 1.2 features. > > Acked-by: Keith Busch Thanks, applied to the block branch. Kevin