From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols
Date: Fri, 8 May 2015 12:34:48 +0200 [thread overview]
Message-ID: <20150508103448.GD4318@noname.redhat.com> (raw)
In-Reply-To: <554C8D1B.8030307@redhat.com>
Am 08.05.2015 um 12:16 hat Paolo Bonzini geschrieben:
> On 08/05/2015 12:08, Kevin Wolf wrote:
> > If so, the commands seem to be hopelessly underspecified, especially
> > with respect to error conditions. And where it says something about
> > errors, it doesn't make sense: The server is forbidden to reply to a
> > NBD_CMD_FLUSH if it failed... (qemu-nbd ignores this, obviously)
>
> So does nbd-server. O:-) Looks like you're reading the spec too
> literally (which is never a bad thing).
I don't think there is something like reading a spec too literally.
Specs are meant to be read literally. If a specification is open to
interpretation, you don't need it. So I'd rather say I've found a bug
in the spec. ;-)
As you already seem to be working on the NBD mailing list, do you want
to fix this, or should I subscribe and send a patch myself?
Kevin
next prev parent reply other threads:[~2015-05-08 10:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:03 [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols Max Reitz
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 1/3] iotests: Make nested read in 072 and 089 read-only Max Reitz
2015-03-19 19:23 ` Eric Blake
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 2/3] block: Introduce BDS.growing Max Reitz
2015-03-19 20:11 ` Eric Blake
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 3/3] block: Introduce BlockDriver.requires_growing_file Max Reitz
2015-03-19 20:18 ` Eric Blake
2015-05-05 9:46 ` [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols Stefan Hajnoczi
2015-05-06 13:04 ` Max Reitz
2015-05-06 15:30 ` Paolo Bonzini
2015-05-06 16:12 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-06 16:20 ` Paolo Bonzini
2015-05-06 16:37 ` Max Reitz
2015-05-06 16:47 ` Paolo Bonzini
2015-05-06 17:23 ` Max Reitz
2015-05-07 12:20 ` Paolo Bonzini
2015-05-07 12:29 ` Kevin Wolf
2015-05-07 12:47 ` Paolo Bonzini
2015-05-07 13:20 ` Kevin Wolf
2015-05-07 13:55 ` Paolo Bonzini
2015-05-07 14:07 ` Kevin Wolf
2015-05-07 14:16 ` Paolo Bonzini
2015-05-07 14:34 ` Kevin Wolf
2015-05-07 14:50 ` Paolo Bonzini
2015-05-08 10:08 ` Kevin Wolf
2015-05-08 10:16 ` Paolo Bonzini
2015-05-08 10:34 ` Kevin Wolf [this message]
2015-05-08 11:00 ` Paolo Bonzini
2015-05-08 12:58 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508103448.GD4318@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).