From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrka9-00041P-59 for qemu-devel@nongnu.org; Mon, 11 May 2015 06:05:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrka3-0006Ow-IK for qemu-devel@nongnu.org; Mon, 11 May 2015 06:05:05 -0400 Date: Mon, 11 May 2015 12:04:52 +0200 From: Kevin Wolf Message-ID: <20150511100452.GC4962@noname.redhat.com> References: <1431107242-31947-1-git-send-email-dimara@arrikto.com> <1431107242-31947-2-git-send-email-dimara@arrikto.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431107242-31947-2-git-send-email-dimara@arrikto.com> Subject: Re: [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis Cc: pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: > Instead of checking bs->sg use bdrv_is_sg() consistently throughout > the code. > > Signed-off-by: Dimitris Aragiorgis > Reviewed-by: Paolo Bonzini > --- > block.c | 6 +++--- > block/iscsi.c | 2 +- > block/raw-posix.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/block/raw-posix.c b/block/raw-posix.c > index 24d8582..24b061f 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -302,9 +302,9 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp) > BDRVRawState *s = bs->opaque; > char *buf; > > - /* For /dev/sg devices the alignment is not really used. > + /* For SG devices the alignment is not really used. > With buffered I/O, we don't have any restrictions. */ If you want to change this comment, why not "SCSI generic" instead of letting people guess what sg might mean in this context? Kevin