From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Yrklc-00020n-DG
	for qemu-devel@nongnu.org; Mon, 11 May 2015 06:16:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YrklX-0001p1-EZ
	for qemu-devel@nongnu.org; Mon, 11 May 2015 06:16:56 -0400
Date: Mon, 11 May 2015 12:16:44 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150511101644.GE4962@noname.redhat.com>
References: <1431107242-31947-1-git-send-email-dimara@arrikto.com>
	<1431107242-31947-4-git-send-email-dimara@arrikto.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431107242-31947-4-git-send-email-dimara@arrikto.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of
	DEBUG_BLOCK_PRINT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dimitris Aragiorgis <dimara@arrikto.com>
Cc: pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben:
> Building the QEMU tools fails if we #define DEBUG_BLOCK inside
> block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
> so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
> a simple DPRINTF().
> 
> Signed-off-by: Dimitris Aragiorgis <dimara@arrikto.com>

Why is this better than linking in qemu-log.o?

>  block/raw-posix.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 24b061f..fbccca8 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -97,11 +97,11 @@
>  //#define DEBUG_FLOPPY
>  
>  //#define DEBUG_BLOCK
> -#if defined(DEBUG_BLOCK)
> -#define DEBUG_BLOCK_PRINT(formatCstr, ...) do { if (qemu_log_enabled()) \
> -    { qemu_log(formatCstr, ## __VA_ARGS__); qemu_log_flush(); } } while (0)
> +
> +#ifdef DEBUG_BLOCK
> +#define DPRINTF(fmt, ...) do { printf(fmt, ## __VA_ARGS__); } while (0)

Please use stderr at least if you don't respect the log file setting.

>  #else
> -#define DEBUG_BLOCK_PRINT(formatCstr, ...)
> +#define DPRINTF(fmt, ...) do { } while (0)
>  #endif

Kevin