From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YrlhS-00068A-Tx
	for qemu-devel@nongnu.org; Mon, 11 May 2015 07:16:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YrlhN-0000WD-Vt
	for qemu-devel@nongnu.org; Mon, 11 May 2015 07:16:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42717)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YrlhN-0000Vp-Ro
	for qemu-devel@nongnu.org; Mon, 11 May 2015 07:16:37 -0400
Date: Mon, 11 May 2015 16:46:27 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150511111627.GC11321@grmbl.mre>
References: <1429031053-4454-1-git-send-email-dgilbert@redhat.com>
	<1429031053-4454-3-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429031053-4454-3-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 02/47] Split header writing out of
 qemu_savevm_state_begin
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, yayanghy@cn.fujitsu.com

On (Tue) 14 Apr 2015 [18:03:28], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Split qemu_savevm_state_begin to:
>   qemu_savevm_state_header   That writes the initial file header.
>   qemu_savevm_state_begin    That sets up devices and does the first
>                              device pass.
> 
> Used later in postcopy.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

Function names sound silly now - savevm_state_header() and
savevm_state_begin().

		Amit