From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YrpTE-0007AF-EF
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:18:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YrpT7-0000Bf-D6
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:18:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42697)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YrpT7-0000BZ-4u
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:18:09 -0400
Date: Mon, 11 May 2015 17:17:53 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150511171529-mutt-send-email-mst@redhat.com>
References: <1431329108-2605-1-git-send-email-mst@redhat.com>
	<1431329108-2605-24-git-send-email-mst@redhat.com>
	<5550C4BD.6030500@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5550C4BD.6030500@redhat.com>
Subject: Re: [Qemu-devel] [PULL 23/28] qmp-event: add event notification for
 memory hot unplug error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Mon, May 11, 2015 at 09:03:25AM -0600, Eric Blake wrote:
> On 05/11/2015 06:48 AM, Michael S. Tsirkin wrote:
> > From: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
> > 
> > When memory hot unplug fails, this patch adds support to send
> > QMP event to notify mgmt about this failure.
> > 
> > Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  qapi/event.json          | 14 ++++++++++++++
> >  hw/acpi/memory_hotplug.c | 10 +++++++++-
> >  docs/qmp/qmp-events.txt  | 17 +++++++++++++++++
> >  trace-events             |  1 +
> >  4 files changed, 41 insertions(+), 1 deletion(-)
> 
> I missed reviewing this earlier; and since it is now in a PULL request,
> you'll need a followup patch:
> 
> 
> > +
> > +##
> > +# @MEM_UNPLUG_ERROR
> > +#
> > +# Emitted when memory hot unplug error occurs.
> > +#
> > +# @device: device name
> > +#
> > +# @msg: Informative message
> > +#
> > +# Since: 2.4
> > +##
> > +{ 'event': 'MEM_UNPLUG_ERROR',
> 
> The name here...
> 
> 
> > +++ b/docs/qmp/qmp-events.txt
> > @@ -226,6 +226,23 @@ Example:
> >  { "event": "GUEST_PANICKED",
> >       "data": { "action": "pause" } }
> >  
> > +MEM_HOT_UNPLUG_ERROR
> 
> ...needs to be the same one used here.
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


It's just a doc bug so I'll let it stand, we can
fix it by a follow-up patch.

-- 
MST