From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: pbonzini@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/3] block: Fix NULL deference for unaligned write if qiov is NULL
Date: Tue, 12 May 2015 11:33:40 +0800 [thread overview]
Message-ID: <20150512033340.GA2007@ad.nay.redhat.com> (raw)
In-Reply-To: <20150511144309.GG16270@stefanha-thinkpad.redhat.com>
On Mon, 05/11 15:43, Stefan Hajnoczi wrote:
> On Tue, May 05, 2015 at 10:51:14AM +0800, Fam Zheng wrote:
>
> This function is complex. I had to draw a diagram to remember the
> relationships between the variables. It would be nice to split it if
> that can be done in a way that makes the code nicer.
OK. I can split zero write to a separate function.
next prev parent reply other threads:[~2015-05-12 3:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 2:51 [Qemu-devel] [PATCH v5 0/3] block: Fix unaligned bdrv_aio_write_zeroes Fam Zheng
2015-05-05 2:51 ` [Qemu-devel] [PATCH v5 1/3] Revert "block: Fix unaligned zero write" Fam Zheng
2015-05-11 14:46 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-05 2:51 ` [Qemu-devel] [PATCH v5 2/3] block: Fix NULL deference for unaligned write if qiov is NULL Fam Zheng
2015-05-11 14:43 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-12 3:33 ` Fam Zheng [this message]
2015-05-05 2:51 ` [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Test unaligned sub-block zero write Fam Zheng
2015-05-11 14:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512033340.GA2007@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).