From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37283)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys6MW-0005KS-Ea
	for qemu-devel@nongnu.org; Tue, 12 May 2015 05:20:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys6MT-0007fc-77
	for qemu-devel@nongnu.org; Tue, 12 May 2015 05:20:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45598)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Ys6MT-0007dY-0L
	for qemu-devel@nongnu.org; Tue, 12 May 2015 05:20:25 -0400
Date: Tue, 12 May 2015 10:20:15 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150512092015.GF18200@redhat.com>
References: <00c901d08990$2763c410$762b4c30$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <00c901d08990$2763c410$762b4c30$@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, qemu-devel@nongnu.org

On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote:
>  I would like to offer this, slightly improved implementation. The key thing is a new
> kernel_irqchip_type member in Machine class. Currently it it used only by virt machine for
> its internal purposes, however in future it is to be passed to KVM in
> kvm_irqchip_create(). The variable is defined as int in order to be architecture agnostic,
> for potential future users.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> ---
>  hw/arm/virt.c       | 155 +++++++++++++++++++++++++++++++++++++++++++---------
>  include/hw/boards.h |   1 +
>  2 files changed, 130 insertions(+), 26 deletions(-)

> +#define TYPE_VIRTV3_MACHINE   "virt-v3"

[snip]

> +static const TypeInfo machvirtv3_info = {
> +    .name = TYPE_VIRTV3_MACHINE,
> +    .parent = TYPE_VIRT_MACHINE,
> +    .instance_size = sizeof(VirtMachineState),
> +    .instance_init = virtv3_instance_init,
> +    .class_size = sizeof(VirtMachineClass),
> +    .class_init = virtv3_class_init,
> +};
> +
>  static void machvirt_machine_init(void)
>  {
>      type_register_static(&machvirt_info);
> +    type_register_static(&machvirtv3_info);
>  }

If we're going to start adding new machine types for aarch64 with
version numbers, then I think we should we be using a versioning
scheme that matches what we do on x86. ie, define versioned
machine types based on the QEMU release numbers

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|