From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsShP-00066H-Eb for qemu-devel@nongnu.org; Wed, 13 May 2015 05:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsShO-0003gu-BH for qemu-devel@nongnu.org; Wed, 13 May 2015 05:11:31 -0400 Date: Wed, 13 May 2015 11:11:19 +0200 From: Kevin Wolf Message-ID: <20150513091119.GC4263@noname.str.redhat.com> References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-15-git-send-email-kwolf@redhat.com> <55525CDE.7030505@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MW5yreqqjyrRcusr" Content-Disposition: inline In-Reply-To: <55525CDE.7030505@redhat.com> Subject: Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mreitz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com --MW5yreqqjyrRcusr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 12.05.2015 um 22:04 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > Eventually we want to be able to change options at runtime. As a first > > step towards that goal, separate some option handling code from the > > general initialisation code in qcow2_open(). > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block/qcow2.c | 135 +++++++++++++++++++++++++++++++++-----------------= -------- > > 1 file changed, 76 insertions(+), 59 deletions(-) > >=20 > > + } else { > > + error_setg(errp, "Unsupported value '%s' for qcow2 option " > > + "'overlap-check'. Allowed are either of the followi= ng: " > > + "none, constant, cached, all", opt_overlap_check); >=20 > Pre-existing due to code motion, but I find s/either/any/ easier to read. Isn't "either" only for a choice between two things anyway? The series isn't long enough yet, I'll fix it. :-) Kevin --MW5yreqqjyrRcusr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVUxU3AAoJEH8JsnLIjy/WSjkQAME5brV8zXTT9KKKVgS8Cb7y F3wDD3IZMf3Vmpo4GuaKJp9wqpXqAKl8JkzjhqSU3JaQY7SB1dICwvx00MeanBAe s3FnK4Qn1mt3ucJuQzaeJ4DgQ+RFOH40R5ipWvHOJbLQNIGtgHdxjs1/OuFkotek FNM1eenhyK7zx+nxnPq4j+D5jYf/AaKlR1B91PpVbGXNhvKIy1TePm7LouW7gnJL KbInQs4w+35mDd20pPnuWdPssBirQsCf622G3IOS5LFkyFmomlcvqCICXMhLJgp6 biOK24avP7HMbHNgUSGdg/2dsPL5Gqm2FCIL+6pTwKmjMXthwbSPT+zLK5xKYT/G MK4XJmk8jgHOL2buseGaesvZ8LLfWgUn/JB4vbxTvWCsqcLvmFfv9sVpwGb6a8vh Vus1Yr35wD/DlssXhLV3RTasWieyujQMfLLfll0Zhlo+K6+PGH+BCxu25DFWckV6 S1rNIpxMXGefHWO3IlwoYJpgKHM7KxbXpvSOXwPG0rWHZFRO8jOAEEoTnK2caOqs q56ZQQHmcY9kkjYfTKaRH187PHy8IogUevr9YQlpKRc/YO/wLRLlidzMeq1DhTi1 WtodPQZMB4knsz/Bq8iDkA4kDHfHPZtDS1Pr6l3Drqp1hBa883IIvrqfboL5KgJ5 XCi3xA5AQRsFDTrh303f =sMV6 -----END PGP SIGNATURE----- --MW5yreqqjyrRcusr--