Re: [Qemu-devel] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker

[Fam Zheng <famz@redhat.com>]

On Wed, 05/13 12:26, Paolo Bonzini wrote:
> 
> 
> On 13/05/2015 19:28, Fam Zheng wrote:
> > +static void virtio_blk_data_plane_pause(VirtIOBlock *vblk)
> > +{
> > +    VirtIOBlockDataPlane *s = vblk->dataplane;
> > +
> > +    event_notifier_test_and_clear(&s->host_notifier);
> > +    aio_set_event_notifier(s->ctx, &s->host_notifier, NULL);
> > +}
> > +
> > +static void handle_notify(EventNotifier *e);
> > +static void virtio_blk_data_plane_resume(VirtIOBlock *vblk)
> > +{
> > +    VirtIOBlockDataPlane *s = vblk->dataplane;
> > +
> > +    aio_set_event_notifier(s->ctx, &s->host_notifier, handle_notify);
> > +
> > +    event_notifier_set(&s->host_notifier);
> > +}
> 
> Perhaps add a note that these are called under aio_context_acquire?
> 

OK, good idea.

Fam