From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsWD7-00086x-5N for qemu-devel@nongnu.org; Wed, 13 May 2015 08:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsWD3-0000Bw-M8 for qemu-devel@nongnu.org; Wed, 13 May 2015 08:56:29 -0400 Date: Wed, 13 May 2015 20:55:06 +0800 From: Fam Zheng Message-ID: <20150513125506.GD30644@ad.nay.redhat.com> References: <1431538099-3286-1-git-send-email-famz@redhat.com> <1431538099-3286-11-git-send-email-famz@redhat.com> <555333F9.5010307@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555333F9.5010307@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Kevin Wolf , qemu-block@nongnu.org, armbru@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com On Wed, 05/13 19:22, Wen Congyang wrote: > On 05/14/2015 01:28 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > blockdev.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/blockdev.c b/blockdev.c > > index ae52d27..bd28183 100644 > > --- a/blockdev.c > > +++ b/blockdev.c > > @@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState { > > BlockDriverState *bs; > > BlockJob *job; > > AioContext *aio_context; > > + Error *blocker; > > } BlockdevBackupState; > > > > static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) > > @@ -1685,6 +1686,10 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) > > } > > aio_context_acquire(state->aio_context); > > > > + state->bs = bs; > > + error_setg(&state->blocker, "blockdev-backup in progress"); > > + bdrv_op_block(bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); > > + > > Do you test this patch? You need to read from bs to do backup!! > If the mode is none, you also need to write to bs!! This blocker is only temporary and is removed in blockdev_backup_clean before qmp_transaction returns. Fam > > Thanks > Wen Congyang > > > qmp_blockdev_backup(backup->device, backup->target, > > backup->sync, > > backup->has_speed, backup->speed, > > @@ -1696,7 +1701,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) > > return; > > } > > > > - state->bs = bs; > > state->job = state->bs->job; > > } > > > > @@ -1715,6 +1719,10 @@ static void blockdev_backup_clean(BlkTransactionState *common) > > { > > BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common); > > > > + if (state->bs) { > > + bdrv_op_unblock(state->bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); > > + error_free(state->blocker); > > + } > > if (state->aio_context) { > > aio_context_release(state->aio_context); > > } > > >