From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YskvW-00028h-DU
	for qemu-devel@nongnu.org; Thu, 14 May 2015 00:39:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YskvP-0002Hx-V1
	for qemu-devel@nongnu.org; Thu, 14 May 2015 00:39:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52889)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YskvP-0002H5-Kl
	for qemu-devel@nongnu.org; Thu, 14 May 2015 00:39:11 -0400
Date: Thu, 14 May 2015 12:39:05 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150514043905.GA11231@ad.nay.redhat.com>
References: <1431574469-9605-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431574469-9605-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 00/13] main-loop: Get rid of
 fd_read_poll and qemu_set_fd_handler2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jason Wang <jasowang@redhat.com>, Vincenzo Maffione <v.maffione@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Luigi Rizzo <rizzo@iet.unipi.it>

On Thu, 05/14 11:34, Fam Zheng wrote:
> Patch 1 adds a stub for qemu_set_fd_handler which will be referenced in coming
> patches.
> 
> Patch 2 converts qemu-nbd which compares two global numbers in the fd_read_poll
> callback.
> 
> Patches 2~5 converts the four net devices, all of which checks
> qemu_can_send_packet() in the callback.

s/2~5/3~6/

> 
> Patch 6 and 7 finally removes the function.

s/6 and 7/7 and 8/


> 
> Please review!
> 
> 
> Fam Zheng (13):
>   stubs: Add qemu_set_fd_handler
>   qemu-nbd: Switch to qemu_set_fd_handler
>   l2tpv3: Drop l2tpv3_can_send
>   netmap: Drop netmap_can_send
>   net/socket: Drop net_socket_can_send
>   tap: Drop tap_can_send
>   Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler
>   main-loop: Drop qemu_set_fd_handler2
>   alsaaudio: Remove unused error handling of qemu_set_fd_handler
>   oss: Remove unused error handling of qemu_set_fd_handler
>   xen_backend: Remove unused error handling of qemu_set_fd_handler
>   event-notifier: Always return 0 for posix implementation
>   iohandler: Use AioContext internally