From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults
Date: Thu, 14 May 2015 07:45:38 +0200 [thread overview]
Message-ID: <20150514074330-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <555426C0.9020402@weilnetz.de>
On Thu, May 14, 2015 at 06:38:24AM +0200, Stefan Weil wrote:
> Am 13.05.2015 um 20:15 schrieb Stefano Stabellini:
> >On Wed, 13 May 2015, Daniel P. Berrange wrote:
> >>On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote:
> >>>Do not emulate a floppy drive if no drives are supposed to be present.
> >>>
> >>>This fixes the behavior of -nodefaults, that should remove the floppy
> >>>drive (see docs/qdev-device-use.txt:Default Devices), but actually
> >>>doesn't.
> >>Technically that doc is just refering to the disablement of the
> >>primary floppy drive, as opposed to the floppy controller. The
> >>floppy controller itself is really a built-in device that is
> >>defined as part of the machine type, along with the various other
> >>platform devices hanging off the PIIX and ISA brige.
> >I think you are right, this patch is a bit too harsh in fixing the
> >problem: I just wanted to properly disable drive emulation, because from
> >my tests the guest thinks that one drive is present even when is not.
>
> A short test on some of my physical machines shows that most
> of them don't have a floppy disk controller at all (dmesg | grep FDC).
>
> Only some older machines still have one.
>
> Therefore I think that QEMU must also be able to offer a virtual
> machine without an FDC, maybe as the default for the next
> version of QEMU.
>
> Stefan
Making it the default in QEMU might break a bunch of existing setups,
but IMO it's very reasonable to add such a property, and teach libvirt
to set it automatically.
--
MST
next prev parent reply other threads:[~2015-05-14 5:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 17:29 [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults Stefano Stabellini
2015-05-13 17:42 ` Daniel P. Berrange
2015-05-13 18:15 ` Stefano Stabellini
2015-05-13 21:46 ` John Snow
2015-05-14 11:12 ` Stefano Stabellini
2015-05-14 11:18 ` Daniel P. Berrange
2015-05-14 11:46 ` Michael S. Tsirkin
2015-05-14 12:02 ` Markus Armbruster
2015-05-14 12:11 ` Paolo Bonzini
2015-05-14 12:45 ` Markus Armbruster
2015-05-14 12:48 ` Daniel P. Berrange
2015-05-14 12:53 ` Paolo Bonzini
2015-05-14 13:25 ` [Qemu-devel] [Xen-devel] " Sander Eikelenboom
2015-05-14 13:41 ` Daniel P. Berrange
2015-05-14 13:55 ` Paolo Bonzini
2015-05-14 14:39 ` Stefano Stabellini
2015-05-14 14:44 ` Paolo Bonzini
2015-05-14 14:52 ` Stefano Stabellini
2015-05-14 13:57 ` Michael S. Tsirkin
2015-05-14 14:07 ` [Qemu-devel] " Michael S. Tsirkin
2015-05-14 17:54 ` John Snow
2015-05-15 7:50 ` Markus Armbruster
2015-05-15 8:19 ` Paolo Bonzini
2015-05-15 10:20 ` Stefano Stabellini
2015-05-18 9:19 ` Kevin Wolf
2015-05-14 11:47 ` Michael S. Tsirkin
2015-05-14 11:54 ` Paolo Bonzini
2015-05-14 11:56 ` Michael S. Tsirkin
2015-05-14 12:47 ` Markus Armbruster
2015-05-14 4:38 ` Stefan Weil
2015-05-14 5:45 ` Michael S. Tsirkin [this message]
2015-05-13 21:44 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514074330-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefano.stabellini@eu.citrix.com \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).