From: Fam Zheng <famz@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, armbru@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 01/12] block: Add op blocker type "device IO"
Date: Fri, 15 May 2015 15:06:37 +0800 [thread overview]
Message-ID: <20150515070637.GB13255@ad.nay.redhat.com> (raw)
In-Reply-To: <555590B1.1050104@cn.fujitsu.com>
On Fri, 05/15 14:22, Wen Congyang wrote:
> On 05/15/2015 02:04 PM, Fam Zheng wrote:
> > It blocks device IO.
>
> I am reading mirror codes recently, and have a question:
> When block job mirror is finished, the source and target is synced. But we
> call bdrv_swap() later(in bh context). Can the guest write something to
> the source before the bh is scheduled? If the answer is yes, I think
> we should use this to block the guest's disk I/O.
I think you're right. After mirror_run returns, anything can happen on this aio
context, including guest writing.
Fam
next prev parent reply other threads:[~2015-05-15 7:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 6:04 [Qemu-devel] [PATCH v3 00/12] Fix transactional snapshot with dataplane and NBD export Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 01/12] block: Add op blocker type "device IO" Fam Zheng
2015-05-15 6:22 ` Wen Congyang
2015-05-15 7:06 ` Fam Zheng [this message]
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 02/12] block: Add op blocker notifier list Fam Zheng
2015-05-18 17:22 ` Max Reitz
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 03/12] block-backend: Add blk_op_blocker_add_notifier Fam Zheng
2015-05-18 17:24 ` Max Reitz
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 04/12] virtio-blk: Move complete_request to 'ops' structure Fam Zheng
2015-05-18 17:38 ` Max Reitz
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 05/12] virtio-blk: Don't handle output when there is "device IO" op blocker Fam Zheng
2015-05-18 18:19 ` Max Reitz
2015-05-19 2:58 ` Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 06/12] nbd-server: Clear "can_read" when "device io" blocker is set Fam Zheng
2015-05-18 18:35 ` Max Reitz
2015-05-19 2:26 ` Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 07/12] blockdev: Block device IO during internal snapshot transaction Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 08/12] blockdev: Block device IO during external " Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 09/12] blockdev: Block device IO during drive-backup transaction Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 10/12] blockdev: Block device IO during blockdev-backup transaction Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 11/12] block: Block "device IO" during bdrv_drain and bdrv_drain_all Fam Zheng
2015-05-15 6:04 ` [Qemu-devel] [PATCH v3 12/12] virtio-scsi-dataplane: Add "device IO" op blocker listener Fam Zheng
2015-05-15 6:50 ` Paolo Bonzini
2015-05-15 7:03 ` Fam Zheng
2015-05-15 7:26 ` Paolo Bonzini
2015-05-15 7:57 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515070637.GB13255@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).