From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtBlh-0001xM-6o for qemu-devel@nongnu.org; Fri, 15 May 2015 05:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtBlg-00018L-7U for qemu-devel@nongnu.org; Fri, 15 May 2015 05:18:57 -0400 Date: Fri, 15 May 2015 17:18:47 +0800 From: Fam Zheng Message-ID: <20150515091847.GE13255@ad.nay.redhat.com> References: <0faf3d82dca9bf334d99f761e84874cb36fa466b.1431523498.git.berto@igalia.com> <20150515025609.GM28144@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 11/11] qemu-iotests: test overlapping block-stream operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org On Fri, 05/15 10:58, Alberto Garcia wrote: > On Fri 15 May 2015 04:56:09 AM CEST, Fam Zheng wrote: > > >> + # If node4 is the active node, the id of the block job is drive0 > >> + if self.num_imgs == 5: > > > > Isn't self.num_imgs a constant (9) ? > > Yes, but the number is arbitrary. The idea is to let users change it if > they want to, so the test case must be prepared for that. > They have to change the code to get a different value, no? This is unreachable code as is and IMO even if you're not as considerate on this, whoever changes num_ops should make sure code that uses it still works. This is bikeshedding, this is a great series, so even if you insist, Reviewed-by: Fam Zheng