From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Yu9uo-0000S9-Ho
	for qemu-devel@nongnu.org; Sun, 17 May 2015 21:32:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Yu9ul-0000Dk-CE
	for qemu-devel@nongnu.org; Sun, 17 May 2015 21:32:22 -0400
Date: Mon, 18 May 2015 09:32:12 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150518013212.GA19546@ad.nay.redhat.com>
References: <1431667606-14467-1-git-send-email-famz@redhat.com>
	<5556317B.4080604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5556317B.4080604@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests
 easier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com

On Fri, 05/15 13:48, John Snow wrote:
> 
> 
> On 05/15/2015 01:26 AM, Fam Zheng wrote:
> > Adding "-d" option. The output goes to "tee" so it appears in your
> > console. Also, raise the verbosity of unnitest runner.
> > 
> > When testing a topic branch, it's possible that a bug introduced by a
> > code change makes the python test case hang, with debug output, it is
> > much easier to locate the problem.
> > 
> > This can also be helpful if you want to watch the progress of a python
> > test, it offers you a way to sense the speed of each test case method
> > you're writing.
> > 
> 
> Awesome idea!
> 
> Unfortunately, it explodes when I run ./check -v -d -qcow2 124:
> 
> +Traceback (most recent call last):
> +  File "124", line 363, in <module>
> +    iotests.main(supported_fmts=['qcow2'])
> +  File "/home/bos/jhuston/src/qemu/tests/qemu-iotests/iotests.py", line
> 367, in main
> +    sys.stderr.write(re.sub(r'Ran (\d+) tests? in [\d.]+s', r'Ran \1
> tests', output.getvalue()))
> +AttributeError: 'file' object has no attribute 'getvalue'
> Failures: 124
> Failed 1 of 1 tests
> 
> --js

I guess we can skip this line if debug is True. (However, I should have noted
in the commit message, by specifying "-d", the purpose of the execution is
solely *debugging the test itself*, and because I didn't find a easy way to get
*both* the verbose debug output and an output that would match $seq.out, this
patch always makes a "-d" execution fail.)

Will send another version with an additional "if debug".

Thanks,

Fam