From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuIOG-0006Io-AZ for qemu-devel@nongnu.org; Mon, 18 May 2015 06:35:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuIOC-0002vR-W2 for qemu-devel@nongnu.org; Mon, 18 May 2015 06:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuIOC-0002vM-Qe for qemu-devel@nongnu.org; Mon, 18 May 2015 06:35:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 478818EA57 for ; Mon, 18 May 2015 10:35:15 +0000 (UTC) Date: Mon, 18 May 2015 11:35:11 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150518103510.GE2201@work-vm> References: <1431620920-19710-1-git-send-email-quintela@redhat.com> <1431620920-19710-4-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431620920-19710-4-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > This allows us to store the current state to send it through migration. > > Signed-off-by: Juan Quintela > --- > include/sysemu/sysemu.h | 1 + > vl.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 8a52934..c1a403e 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -28,6 +28,7 @@ bool runstate_check(RunState state); > void runstate_set(RunState new_state); > int runstate_is_running(void); > bool runstate_needs_reset(void); > +int runstate_store(char *str, int size); > typedef struct vm_change_state_entry VMChangeStateEntry; > typedef void VMChangeStateHandler(void *opaque, int running, RunState state); > > diff --git a/vl.c b/vl.c > index 15bccc4..7dca13f 100644 > --- a/vl.c > +++ b/vl.c > @@ -609,6 +609,17 @@ bool runstate_check(RunState state) > return current_run_state == state; > } > > +int runstate_store(char *str, int size) > +{ size_t size and perhaps a bool for the return type? > + const char *state = RunState_lookup[current_run_state]; > + > + if (strlen(state)+1 > size) { > + return -1; > + } > + strncpy(str, state, strlen(state)+1); Why not a plain strcpy? (I'd be very tempted by an assert if it's too long; I mean it really shouldn't happen; although I don't like asserts in the migrate path). Dave > + return 0; > +} > + > static void runstate_init(void) > { > const RunStateTransition *p; > -- > 2.4.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK