From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuK5A-0005HN-A0 for qemu-devel@nongnu.org; Mon, 18 May 2015 08:23:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuK59-0008Ay-2b for qemu-devel@nongnu.org; Mon, 18 May 2015 08:23:44 -0400 Date: Mon, 18 May 2015 13:23:31 +0100 From: Stefan Hajnoczi Message-ID: <20150518122331.GA24319@stefanha-thinkpad.redhat.com> References: <1429747493-24397-1-git-send-email-jsnow@redhat.com> <1429747493-24397-4-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline In-Reply-To: <1429747493-24397-4-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 03/10] block: rename BlkTransactionState and BdrvActionOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 22, 2015 at 08:04:46PM -0400, John Snow wrote: > These structures are misnomers, somewhat. >=20 > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. >=20 > (2) The BdrvActionOps describes operations for the BlkActionState, > above. This name might imply a 'BdrvAction' or a 'BdrvActionState', > which there isn't. > Rename this to 'BlkActionOps' to match 'BlkActionState'. >=20 > Lastly, update the surrounding in-line documentation and comments > to reflect the current nature of how Transactions operate. >=20 > This patch changes only comments and names, and should not affect > behavior in any way. >=20 > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > blockdev.c | 114 ++++++++++++++++++++++++++++++++++---------------------= ------ > 1 file changed, 64 insertions(+), 50 deletions(-) Reviewed-by: Stefan Hajnoczi --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVWdnDAAoJEJykq7OBq3PIS1oIAIQMf+7G2De+RifPsb5NeNh+ qZdMzI5XRkGPo8uhmlCAkf4day2NRgVa/7R2hsUf0WhacPcRtgEsdE04rmi0IWyg hZ6tiybwvNFenSXeMzi395wOfgj9wccygEHN6fbUuK7gsEuZT5OVUqhmTSWYFJtV 7vJt7PyL+sdls5eVvWj6EDsCzletbqNFCfJLk+89dVLB+6fNWOSezq6CMAo99rhQ 0SbH4Ypw0aS3roulthBipngYMuKcN8Gr4nqADvvqjVHMdfSRjCx18gxYzHZhqgXt ymZ2iqOyz4b3Pe3l/E8n1GtzhN+eWinKlxDctiJ7N1l8yaSKJ8/ymwctbK+9yjE= =Wk3X -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy--