From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuK6O-0006ij-C5 for qemu-devel@nongnu.org; Mon, 18 May 2015 08:25:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuK6K-0000BL-Kc for qemu-devel@nongnu.org; Mon, 18 May 2015 08:25:00 -0400 Date: Mon, 18 May 2015 13:24:43 +0100 From: Stefan Hajnoczi Message-ID: <20150518122443.GB24319@stefanha-thinkpad.redhat.com> References: <1431385466-4868-1-git-send-email-jsnow@redhat.com> <1431385466-4868-4-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WhfpMioaduB5tiZL" Content-Disposition: inline In-Reply-To: <1431385466-4868-4-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 03/11] block: rename BlkTransactionState and BdrvActionOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 11, 2015 at 07:04:18PM -0400, John Snow wrote: > These structures are misnomers, somewhat. >=20 > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. >=20 > (2) The BdrvActionOps describes operations for the BlkActionState, > above. This name might imply a 'BdrvAction' or a 'BdrvActionState', > which there isn't. > Rename this to 'BlkActionOps' to match 'BlkActionState'. >=20 > Lastly, update the surrounding in-line documentation and comments > to reflect the current nature of how Transactions operate. >=20 > This patch changes only comments and names, and should not affect > behavior in any way. >=20 > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > blockdev.c | 116 ++++++++++++++++++++++++++++++++++---------------------= ------ > 1 file changed, 65 insertions(+), 51 deletions(-) Reviewed-by: Stefan Hajnoczi --WhfpMioaduB5tiZL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVWdoLAAoJEJykq7OBq3PIMV0IAIl7nKbp6A7T5EGbNggJr7fs Dw5hImTA/cgKQA1u8wuwyv0HIrWBoFoTnK6dnl1mJdQJsDcIQqW12zGeBIF3uBFH SdGGtYVlFtpOJzCwatFfa9xkHgdI8Pe4cnaYYjUc/aTrVRPDzQ+Qv9GC6e+F3HFX YBIUqXHn0lCfUwhPhVZWdGFYJLdEYMBTM7NsWlu66/B56yhNdnYlvLNUigWXCRrA 7eu11L5AgxOT3YYoJIS2g4s/GAHIBLGrmpp/Bi1bDQywd7h3LYHFk0yK+C6wqpV8 ezUdYWLDi+WbF4QE5707wZp23g4MByHj5mBvg7Eg6UAaVU+vmoSnPceSgkx+zKc= =SQrh -----END PGP SIGNATURE----- --WhfpMioaduB5tiZL--