qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: berto@igalia.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
	armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big
Date: Mon, 18 May 2015 16:51:06 +0200	[thread overview]
Message-ID: <20150518145106.GG5999@noname.str.redhat.com> (raw)
In-Reply-To: <1431678966-16470-1-git-send-email-famz@redhat.com>

Am 15.05.2015 um 10:36 hat Fam Zheng geschrieben:
> v2: Correct detection of overflow. [Markus, Berto]
> 
> If the image has a huge enough virtual size,
> 
>   $ qemu-img info afl9.img
>   qemu-img: Can't get size of device 'image': Unknown error -512
> 
> It's because of the multiplication overflow in the return statement in
> bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to
> return -EFBIG:
> 
>   qemu-img: Can't get size of device 'image': File too large
> 
> Bug reported by Richard Jones in:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1221499

Thanks, applied to the block branch.

Kevin

      parent reply	other threads:[~2015-05-18 14:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15  8:36 [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big Fam Zheng
2015-05-15  8:36 ` [Qemu-devel] [PATCH v2 1/2] block: Detect multiplication overflow in bdrv_getlength Fam Zheng
2015-05-15  8:45   ` Alberto Garcia
2015-05-15  8:36 ` [Qemu-devel] [PATCH v2 2/2] qemu-iotests: qemu-img info on afl VMDK image with a huge capacity Fam Zheng
2015-05-15 12:20 ` [Qemu-devel] [PATCH v2 0/2] block: Fix error code for bdrv_getlength when the image is too big Markus Armbruster
2015-05-18 14:51 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518145106.GG5999@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=famz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).