Re: [Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption

[Kevin Wolf <kwolf@redhat.com>]

Am 12.05.2015 um 18:09 hat Daniel P. Berrange geschrieben:
> I realize that qcow[2] encryption is a feature we have deprecated
> and will remove support for running it with the QEMU system
> emulators in this cycle. We do still need to make sure it continues
> to work for the sake of letting people run qemu-img convert to
> retrieve their data though.
> 
> Some of the other patches I'm working on which introduce a cypto
> cipher API touch this qcow2 code, thus I wanted to be able to test
> that it doesn't break anything.
> 
> I found that qemu-iotests didn't have any coverage of the qcow2
> encryption code. For added fun, I then discovered that qemu-io
> doesn't check if an encryption key is required, so ends up
> writing plain text to the files instead of cipher, and returning
> cipher text for reads, instead of plain text. IOW qemu-io will
> corrupt encrypted qcow2 files on write.
> 
> This series adds some asserts that will protect against this kind
> of mistake, adds support for getting passwords to qemu-io (in the
> same manner that qemu-img supports), and finally adds a test case
> for reading/writing encrypted qcow2.

Thanks, applied to the block branch.

Kevin