From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNZD-0005hw-22 for qemu-devel@nongnu.org; Mon, 18 May 2015 12:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuNZ8-0005Qs-JO for qemu-devel@nongnu.org; Mon, 18 May 2015 12:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNZ8-0005Ql-AL for qemu-devel@nongnu.org; Mon, 18 May 2015 12:06:54 -0400 Date: Mon, 18 May 2015 18:06:48 +0200 From: "Michael S. Tsirkin" Message-ID: <20150518180555-mutt-send-email-mst@redhat.com> References: <1431595182-7552-1-git-send-email-zhaoshenglong@huawei.com> <1431595182-7552-5-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1431595182-7552-5-git-send-email-zhaoshenglong@huawei.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 04/23] hw/acpi/aml-build: Add aml_memory32_fixed() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On Thu, May 14, 2015 at 05:19:23PM +0800, Shannon Zhao wrote: > From: Shannon Zhao >=20 > Add aml_memory32_fixed() for describing device mmio region in resource > template. These can be used to generating DSDT table for ACPI on ARM. >=20 > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Benn=E9e Reviewed-by: Michael S. Tsirkin > --- > hw/acpi/aml-build.c | 25 +++++++++++++++++++++++++ > include/hw/acpi/aml-build.h | 2 ++ > 2 files changed, 27 insertions(+) >=20 > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 77ce00b..ce68d27 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -26,6 +26,7 @@ > #include > #include "hw/acpi/aml-build.h" > #include "qemu/bswap.h" > +#include "qemu/bitops.h" > #include "hw/acpi/bios-linker-loader.h" > =20 > static GArray *build_alloc_array(void) > @@ -48,6 +49,14 @@ static void build_append_byte(GArray *array, uint8_t= val) > g_array_append_val(array, val); > } > =20 > +static void build_append_uint32(GArray *array, uint32_t val) > +{ > + build_append_byte(array, extract32(val, 0, 8)); > + build_append_byte(array, extract32(val, 8, 8)); > + build_append_byte(array, extract32(val, 16, 8)); > + build_append_byte(array, extract32(val, 24, 8)); > +} > + > static void build_append_array(GArray *array, GArray *val) > { > g_array_append_vals(array, val->data, val->len); > @@ -505,6 +514,22 @@ Aml *aml_call4(const char *method, Aml *arg1, Aml = *arg2, Aml *arg3, Aml *arg4) > return var; > } > =20 > +/* > + * ACPI 1.0: 6.4.3.4 Memory32Fixed (Memory Resource Descriptor Macro) > + */ > +Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > + AmlReadAndWrite read_and_write) > +{ > + Aml *var =3D aml_alloc(); > + build_append_byte(var->buf, 0x86); /* Memory32Fixed Resource Descr= iptor */ > + build_append_byte(var->buf, 9); /* Length, bits[7:0] value =3D 9 *= / > + build_append_byte(var->buf, 0); /* Length, bits[15:8] value =3D 0 = */ > + build_append_byte(var->buf, read_and_write); /* Write status, 1 rw= 0 ro */ > + build_append_uint32(var->buf, addr); /* Range base address */ > + build_append_uint32(var->buf, size); /* Range length */ > + return var; > +} > + > /* ACPI 1.0b: 6.4.2.5 I/O Port Descriptor */ > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len) > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 3947201..b1413a3 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -168,6 +168,8 @@ Aml *aml_call1(const char *method, Aml *arg1); > Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2); > Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2, Aml *arg3); > Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Am= l *arg4); > +Aml *aml_memory32_fixed(uint32_t addr, uint32_t size, > + AmlReadAndWrite read_and_write); > Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base, > uint8_t aln, uint8_t len); > Aml *aml_operation_region(const char *name, AmlRegionSpace rs, > --=20 > 2.1.0 >=20