From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33479)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YuadK-0001Qt-Kb
	for qemu-devel@nongnu.org; Tue, 19 May 2015 02:04:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YuadG-00039s-Of
	for qemu-devel@nongnu.org; Tue, 19 May 2015 02:04:06 -0400
Date: Tue, 19 May 2015 11:32:56 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150519060256.GG15452@grmbl.mre>
References: <1432032670-15124-1-git-send-email-famz@redhat.com>
	<1432032670-15124-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432032670-15124-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 02/13] qemu-nbd: Switch to
	qemu_set_fd_handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vincenzo Maffione <v.maffione@gmail.com>, "Vassili Karpov (malc)" <av1474@comtv.ru>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Giuseppe Lettieri <g.lettieri@iet.unipi.it>, Luigi Rizzo <rizzo@iet.unipi.it>

On (Tue) 19 May 2015 [10:50:59], Fam Zheng wrote:
> Achieved by:
> 
> - Remembering the server fd with a global variable, in order to access
>   it from nbd_client_closed.
> 
> - Checking nbd_can_accept() and updating server_fd handler whenever
>   client connects or disconnects.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

(snip)

> +static void nbd_update_server_fd_handler(int fd)
> +{
> +    if (nbd_can_accept()) {
> +        qemu_set_fd_handler(fd, nbd_accept, NULL, (void *)(uintptr_t)fd);
> +    } else {
> +        qemu_set_fd_handler(fd, NULL, NULL, NULL);

The previous patch just introduces a stub for qemu_set_fd_handler(),
so this functionality will break (during bisect) -- can you modify
patch 1 so that things keep working (even by just copying over
qemu_set_fd_handler2() to qemu_set_fd_handler(), and then re-working
that function later?

Or, it may even be possible to rename the function in patch 1, and
then modify it later.  Depends on the flow of the following patches,
but one of these approaches looks better to me.

		Amit