From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yucr7-0002NM-Pj for qemu-devel@nongnu.org; Tue, 19 May 2015 04:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yucr4-0007BT-HM for qemu-devel@nongnu.org; Tue, 19 May 2015 04:26:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yucr4-0007BB-AO for qemu-devel@nongnu.org; Tue, 19 May 2015 04:26:26 -0400 Date: Tue, 19 May 2015 10:26:23 +0200 From: Kevin Wolf Message-ID: <20150519082623.GA3852@noname.str.redhat.com> References: <1430207220-24458-1-git-send-email-den@openvz.org> <20150518164527.GL27654@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <20150518164527.GL27654@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "Denis V. Lunev" , qemu-devel@nongnu.org, Roman Kagan --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 18.05.2015 um 18:45 hat Stefan Hajnoczi geschrieben: > On Tue, Apr 28, 2015 at 10:46:33AM +0300, Denis V. Lunev wrote: > > This patchset provides an ability to create of/write to Parallels > > images and some testing of the new code. Readings and writings are > > optimized out and I expect the same or slightly better performance > > as qcow2. > >=20 > > Changes from v4: > > - parallels format driver marked as bdrv_has_zero_init_1 > > - added missed unlocks to parallels_co_readv/writev on error path, lock= ing > > is shortened and simplified > > - changed test number for created images > > - added check for bdrv_has_zero_init() and availability of bdrv_truncat= e() > > in parallels_open() and proper error handling in alloc_cluster > > - some patch comments are improved > >=20 > > Changes from v3: > > - fixed checkpatch warnings even in just moved code. I am tired of them > > - fixed contingency check in patch 18 > >=20 > > Changes from v2: > > - read performance is almost doubled (up to 360 Mb/sec), write performa= nce > > is improved by 15-20% > > - bat caching approach changed completely. bat_bitmap now contains the = data > > in on-disk format, which allows to use this data for metadata cache > > - incorrect close detection code is added (inuse field in the header) > > - very basic check consistency code added > >=20 > > Changes from v1: > > - patches 13-19 added, which boosts performance from 800 KiB/sec to > > near native performance > >=20 > > Signed-off-by: Denis V. Lunev > > CC: Roman Kagan > > CC: Kevin Wolf > > CC: Stefan Hajnoczi >=20 > Thanks, applied to my master tree: > https://github.com/stefanha/qemu/commits/master Are you sure you didn't intend to apply it to 'block' rather than 'master'? (Just trying to make sure it's not missing from the next pull request.) Kevin --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVWvOuAAoJEH8JsnLIjy/WZv4P/08NFIZyrtlfTXNkVM6v4D3D pS33WFzMkCKbZzkA/tK8Kb78iyQFeTVsbSA3U4xMWHGS34yBBsWnyphDCz90Z4u7 GscebQ3ly2mp+LWGpNNmyNILub9NSUo0w5XFGv5jHf5datLa1gjhiFd3sU5+6HwO 7VeUGPx/eRpqWLObVa0Agra8qs3McofGk3+36NNWjSV2bYGkVNu/DJTa/bzU/6Ox OZok8A9JUClfHzAocA9HlJn3Ya8WU8eeqeifnVR2HvV3uUo8VWW3mduPt4DPyLTr v+T/dq2ynYGoOMdfxxzqnV3fcBd7QhAjLmMt1fm2qnnLhFw192PhVGqxftCS/7iS 5Niem9frDozTBgoJjZkVY4zlfWmOoXY3y+5JMXbPJItWCSrPEMFvkidGi4Grytyv LXUkgB/16C21fY8CQvgqoWti7J6Fq8nBVQPy+oORAqogogSDL11081egTwtxqkU3 W8B5Ig6VgcycS1NjE6qiGaPnuVnd6T5F6u/5EUz4KJPji50Lbtr+dNtD/a6FhpNA E0gEfKzuhmNu2jz5MDqTaM9txmDIGkKG1d2Esj74SeqzfgH+tFDzGHvimhQdzA2f Cuu7uyz+dLJnPfTXseBCuHBWcQ9qeRVY2tF0MUvfrjrZFYieBdXx0tZ0PreR5YUf g0g4sKlIOmrXrhmoZQ5I =45aI -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--